ci: add 180-minute timeout to test-suite jobs#22362
Open
jorgsowa wants to merge 1 commit into
Open
Conversation
The GitHub-hosted test-suite jobs had no timeout-minutes and fell back to GitHub's 6-hour default, so a hung step (e.g. apt) wasted ~6h of runner time. Cap them at 180 min, which clears the slowest legitimate nightly runs (LINUX_X64_ASAN ~158 min) with margin. The self-hosted jobs keep their existing 50-minute caps.
Ayesh
reviewed
Jun 23, 2026
Ayesh
left a comment
Ayesh
left a comment
Member
There was a problem hiding this comment.
Looks good to me. We already use timeouts in other workflows, and I think 180 makes a good limit.
TimWolla
approved these changes
Jun 23, 2026
TimWolla
left a comment
TimWolla
left a comment
Member
There was a problem hiding this comment.
It would be so nice if one could configure a repo-wide default.
iluuu1994
reviewed
Jun 23, 2026
| matrix: ${{ fromJson(inputs.branch).jobs.COMMUNITY.matrix }} | ||
| name: "COMMUNITY_${{ matrix.type }}" | ||
| runs-on: ubuntu-${{ fromJson(inputs.branch).config.ubuntu_version }} | ||
| timeout-minutes: 180 |
Member
There was a problem hiding this comment.
The ASAN community build usually takes just over 5 hours. This will not be enough. Either we need to reduce it, split it up, or stick to the 6 hour limit.
Member
|
I.e. the community build probably didn't hang. It's just very slow. Edit: 
I take it back, it did hang. Regardless, the limit is too low. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most jobs had no timeout minutes and fell back to GitHub's 6-hour default, so a hung step wasted ~6h of runner time. Cap all jobs at 180 min, which clears the slowest nightly runs.
Hitting the 6h ceiling:
Slowest passing jobs: