fix: correct Objection 3 migration issues and fetch port errors

- Remove lingering JSON.stringify calls on 4 auto-serialized JSON columns
  (group create/import, page create/update) — Objection 3 handles this automatically
- Add response.ok checks and AbortSignal.timeout to all 4 fetch call sites
  (contribute, performUpgrade, azure autocomplete, html-image-prefetch)
- html-image-prefetch renderer now skips images without content-type header
  instead of encoding HTML error body as base64 PNG

Author: dalibor31

server/graph/resolvers/contribute.js

@@ -15,8 +15,12 @@ module.exports = {
           body: JSON.stringify({
             query: '{\n  sponsors {\n    list(kind: BACKER) {\n      id\n      source\n      name\n      joined\n      website\n      twitter\n      avatar\n    }\n  }\n}\n',
             variables: {}
-          })
+          }),
+          signal: AbortSignal.timeout(10000)
         })
+        if (!resp.ok) {
+          throw new Error(`Contributors fetch failed with status ${resp.status}`)
+        }
         const data = await resp.json()
         return _.get(data, 'data.sponsors.list', [])
       } catch (err) {

server/graph/resolvers/group.js

@@ -96,8 +96,8 @@ module.exports = {
     async create (obj, args, { req }) {
       const group = await WIKI.models.groups.query().insertAndFetch({
         name: args.name,
-        permissions: JSON.stringify(WIKI.data.groups.defaultPermissions),
-        pageRules: JSON.stringify(WIKI.data.groups.defaultPageRules),
+        permissions: WIKI.data.groups.defaultPermissions,
+        pageRules: WIKI.data.groups.defaultPageRules,
         isSystem: false
       })
       await WIKI.auth.reloadGroups()

server/graph/resolvers/system.js

@@ -92,7 +92,10 @@ module.exports = {
           if (process.env.UPGRADE_COMPANION_REF) {
             upgradeUrl.searchParams.set('container', process.env.UPGRADE_COMPANION_REF)
           }
-          await fetch(upgradeUrl, { method: 'POST' })
+          const upgradeResp = await fetch(upgradeUrl, { method: 'POST', signal: AbortSignal.timeout(30000) })
+          if (!upgradeResp.ok) {
+            throw new Error(`Upgrade companion returned ${upgradeResp.status}`)
+          }
           return {
             responseResult: graphHelper.generateSuccess('Upgrade has started.')
           }
@@ -131,8 +134,8 @@ module.exports = {
           if (args.groupMode === `SINGLE`) {
             const singleGroup = await WIKI.models.groups.query().insert({
               name: `Import_${curDateISO}`,
-              permissions: JSON.stringify(WIKI.data.groups.defaultPermissions),
-              pageRules: JSON.stringify(WIKI.data.groups.defaultPageRules)
+              permissions: WIKI.data.groups.defaultPermissions,
+              pageRules: WIKI.data.groups.defaultPageRules
             })
             groupsCount++
             assignableGroups.push(singleGroup.id)

server/models/pages.js

@@ -309,10 +309,10 @@ module.exports = class Page extends Model {
       publishStartDate: opts.publishStartDate || '',
       title: opts.title,
       toc: '[]',
-      extra: JSON.stringify({
+      extra: {
         js: scriptJs,
         css: scriptCss
-      })
+      }
     })
     const page = await WIKI.models.pages.getPageFromDb({
       path: opts.path,
@@ -428,11 +428,11 @@ module.exports = class Page extends Model {
       publishEndDate: opts.publishEndDate || '',
       publishStartDate: opts.publishStartDate || '',
       title: opts.title,
-      extra: JSON.stringify({
+      extra: {
         ...ogPage.extra,
         js: scriptJs,
         css: scriptCss
-      })
+      }
     }).where('id', ogPage.id)
     let page = await WIKI.models.pages.getPageFromDb(ogPage.id)
 

server/modules/rendering/html-image-prefetch/renderer.js

@@ -2,13 +2,21 @@ const prefetch = async (element) => {
   const url = element.attr(`src`)
   let response
   try {
-    response = await fetch(url)
+    response = await fetch(url, { signal: AbortSignal.timeout(10000) })
   } catch (err) {
     WIKI.logger.warn(`Failed to prefetch ${url}`)
     WIKI.logger.warn(err)
     return
   }
-  const contentType = response.headers.get('content-type') || 'image/png'
+  if (!response.ok) {
+    WIKI.logger.warn(`Failed to prefetch ${url}: HTTP ${response.status}`)
+    return
+  }
+  const contentType = response.headers.get('content-type')
+  if (!contentType) {
+    WIKI.logger.warn(`Failed to prefetch ${url}: missing content-type`)
+    return
+  }
   const buffer = await response.arrayBuffer()
   const image = Buffer.from(buffer).toString('base64')
   element.attr('src', `data:${contentType};base64,${image}`)

server/modules/search/azure/engine.js

@@ -113,8 +113,12 @@ module.exports = {
               autocompleteMode: 'oneTermWithContext',
               search: q,
               suggesterName: 'suggestions'
-            })
+            }),
+            signal: AbortSignal.timeout(10000)
           })
+          if (!suggestResp.ok) {
+            throw new Error(`Azure autocomplete returned ${suggestResp.status}`)
+          }
           const suggestResults = await suggestResp.json()
           suggestions = suggestResults.value.map(s => s.queryPlusText)
         } catch (err) {