Skip to content

Commit 1c7b844

Browse files
more fixes in codesign for macos
1 parent a8a630c commit 1c7b844

1 file changed

Lines changed: 12 additions & 2 deletions

File tree

.github/workflows/release.yml

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,11 +153,21 @@ jobs:
153153
security import certificate.p12 -k build.keychain -P "$MACOS_CERTIFICATE_PWD" -T /usr/bin/codesign
154154
security set-key-partition-list -S apple-tool:,apple: -s -k "$KEYCHAIN_PWD" build.keychain
155155
156-
- name: Run macdeployqt and Sign
156+
- name: Run macdeployqt, Sign and Pack
157157
run: |
158158
cd build/src
159+
160+
# Initialize Identity
159161
IDENTITY=$(security find-identity -v -p codesigning | grep "Developer ID Application" | head -1 | awk '{print $2}')
160-
macdeployqt vchar64.app -dmg -sign="$IDENTITY"
162+
163+
# 1. Prepare Bundle (copy frameworks etc)
164+
macdeployqt vchar64.app
165+
166+
# 2. Sign Bundle (Deep sign with Hardened Runtime and Timestamp)
167+
codesign --deep --force --verbose --options runtime --timestamp --sign "$IDENTITY" vchar64.app
168+
169+
# 3. Create DMG manually
170+
hdiutil create -volname "VChar64" -srcfolder vchar64.app -ov -format UDZO vchar64.dmg
161171
162172
- name: Notarize DMG
163173
env:

0 commit comments

Comments
 (0)