eval: scrub temp file paths from rugo eval error messages

Author: rubiojr

cmd/cmd.go

@@ -370,7 +370,15 @@ func evalAction(ctx context.Context, cmd *cli.Command) error {
 
 	comp := &compiler.Compiler{BaseDir: tmpDir}
 	if err := comp.Run(srcFile); err != nil {
-		return fmt.Errorf("%s", strings.ReplaceAll(err.Error(), srcFile, "eval"))
+		msg := err.Error()
+		// Replace the display path form (relative from CWD, used in error messages).
+		if wd, err2 := os.Getwd(); err2 == nil {
+			if rel, err2 := filepath.Rel(wd, srcFile); err2 == nil {
+				msg = strings.ReplaceAll(msg, rel, "eval")
+			}
+		}
+		msg = strings.ReplaceAll(msg, srcFile, "eval")
+		return fmt.Errorf("%s", msg)
 	}
 	return nil
 }

rats/core/94_eval_cli_test.rugo

@@ -1,4 +1,5 @@
 use "test"
+use "str"
 
 rats "rugo eval with inline argument"
   result = test.run("rugo eval 'puts 1 + 1'")
@@ -53,3 +54,38 @@ rats "rugo eval compilation error"
   result = test.run("rugo eval 'def'")
   test.assert_neq(result["status"], 0)
 end
+
+rats "rugo eval error shows eval not temp path"
+  result = test.run("rugo eval 'def'")
+  test.assert_contains(result["output"], "eval:")
+  test.assert_false(str.contains(result["output"], "/tmp/"))
+  test.assert_false(str.contains(result["output"], "rugo-eval"))
+end
+
+rats "rugo eval unknown package error shows eval not temp path"
+  result = test.run("rugo eval 'import \"nonexistent\"'")
+  test.assert_neq(result["status"], 0)
+  test.assert_contains(result["output"], "eval:")
+  test.assert_false(str.contains(result["output"], "/tmp/"))
+end
+
+rats "rugo eval semicolon error shows eval not temp path"
+  result = test.run("rugo eval 'x = 1; y = 2'")
+  test.assert_neq(result["status"], 0)
+  test.assert_contains(result["output"], "eval:")
+  test.assert_false(str.contains(result["output"], "/tmp/"))
+end
+
+rats "rugo eval parse error shows eval not temp path"
+  result = test.run("rugo eval 'if true'")
+  test.assert_neq(result["status"], 0)
+  test.assert_contains(result["output"], "eval:")
+  test.assert_false(str.contains(result["output"], "/tmp/"))
+end
+
+rats "rugo eval unknown module error shows eval not temp path"
+  result = test.run("rugo eval 'use \"nonexistent\"'")
+  test.assert_neq(result["status"], 0)
+  test.assert_contains(result["output"], "eval:")
+  test.assert_false(str.contains(result["output"], "/tmp/"))
+end