[BUG] - Null Pinter Reference - cartItems - ProcessPaymentServlet.Java

[gandhi-samir]

Description

In ProcessPaymentServlet.java at line 48, there is the possibility of hitting a null pointer reference. Line 46 has a condition to check != null how ever that condition does not cover the for loop of the cartItem list. The If condition (line 46) needs to cover the entire for loop starting at line 48.

Expected behavior

list does not hit null reference when iterating the loop at checkout

Actual behavior

list hits null reference and an error is thrown.

Possible fix

The If condition (line 46) needs to cover the entire for loop starting at line 48.

Steps to reproduce

In ProcessPaymentServlet.java at line 48, there is the possibility of hitting a null pointer reference. Line 46 has a condition to check != null how ever that condition does not cover the for loop of the cartItem list. The If condition (line 46) needs to cover the entire for loop starting at line 48.

Context

Was doing code review and running find bugs on the code

Additional information

No response

[Coderxrohan]

This is problem i think so far...

[Coderxrohan]

Make this changes...

List cartItems = (List) session.getAttribute("cartItems");

if (cartItems != null) {
for (Cart cart : cartItems) {
Book book = cart.getBook();
double bPrice = book.getPrice();
String bCode = book.getBarcode();
String bName = book.getName();
String bAuthor = book.getAuthor();
int availableQty = book.getQuantity();
int qtToBuy = cart.getQuantity();
availableQty = availableQty - qtToBuy;
bookService.updateBookQtyById(bCode, availableQty);
pw.println(this.addBookToCard(bCode, bName, bAuthor, bPrice, availableQty));
session.removeAttribute("qty_" + bCode);
}
}