Merge branch 'main' into tejaswi/codeowners-confidentialrelay

Author: nadahalli

.github/workflows/cre-settings-schema-reminder.yml

@@ -0,0 +1,45 @@
+name: CRE settings schema reminder
+
+on:
+  pull_request:
+
+permissions:
+  contents: read
+  pull-requests: write
+
+jobs:
+  reminder:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Check for // Deprecated in settings.go diff
+        id: deprecated
+        run: |
+          git fetch origin "${{ github.base_ref }}"
+          if git diff "origin/${{ github.base_ref }}...HEAD" -- pkg/settings/cresettings/settings.go \
+            | grep -E '^\+.*// Deprecated' -q; then
+            echo "found=true" >> "$GITHUB_OUTPUT"
+          else
+            echo "found=false" >> "$GITHUB_OUTPUT"
+          fi
+
+      - name: PR reminder
+        if: steps.deprecated.outputs.found == 'true'
+        uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 # v4.0.0
+        with:
+          issue-number: ${{ github.event.pull_request.number }}
+          edit-mode: replace
+          body-includes: "<!-- cre-settings-schema-reminder -->"
+          body: |
+            <!-- cre-settings-schema-reminder -->
+            ### CRE settings field deprecated
+
+            This PR adds `// Deprecated` in [`pkg/settings/cresettings/settings.go`](https://github.com/smartcontractkit/chainlink-common/blob/main/pkg/settings/cresettings/settings.go).
+
+			If the deprecated field is being replaced by a new one, then a smooth deployment migration requires:
+
+			1. Before deploying the code, any overridden values on the old field must be duplicated to the new field.
+			2. Old field overrides must remain in-place and kept in-sync until all nodes are migrated.

pkg/workflows/wasm/host/standard_test.go

@@ -529,7 +529,7 @@ func TestStandardTeeRuntime(t *testing.T) {
 	t.Parallel()
 
 	cfg := defaultNoDAGModCfg(t)
-	m := makeTestModuleWithConfig(t, cfg)
+	m := makeOptionalTestModuleWithConfig(t, cfg)
 	mockExecutionHelper := mocks.NewMockExecutionHelper(t)
 	mockExecutionHelper.EXPECT().GetWorkflowExecutionID().Return("id")
 	mockExecutionHelper.EXPECT().GetNodeTime().RunAndReturn(func() time.Time {
@@ -612,14 +612,29 @@ func makeTestModule(t *testing.T) *module {
 
 func makeTestModuleWithConfig(t *testing.T, cfg *ModuleConfig) *module {
 	testName := strcase.ToSnake(t.Name()[len("TestStandard"):])
-	return makeTestModuleByName(t, testName, cfg)
+	return makeTestModuleByName(t, testName, cfg, true)
 }
 
-func makeTestModuleByName(t *testing.T, testName string, cfg *ModuleConfig) *module {
+func makeOptionalTestModuleWithConfig(t *testing.T, cfg *ModuleConfig) *module {
+	testName := strcase.ToSnake(t.Name()[len("TestStandard"):])
+	return makeTestModuleByName(t, testName, cfg, false)
+}
+
+func makeTestModuleByName(t *testing.T, testName string, cfg *ModuleConfig, required bool) *module {
 	wasmName := path.Join(testName, "test.wasm")
-	cmd := exec.Command("make", wasmName) // #nosec
 	absPath, err := filepath.Abs(testPath)
 	require.NoError(t, err, "Failed to get absolute path for test directory")
+
+	// An optional test is one whose SDK feature may not be released yet, in which case its
+	// source directory won't exist. Skip only in that case; any other make failure (e.g. a
+	// compilation error in an existing test) must still fail so we don't hide regressions.
+	if !required {
+		if _, statErr := os.Stat(filepath.Join(absPath, testName)); errors.Is(statErr, os.ErrNotExist) {
+			t.Skipf("Optional test %q not found", testName)
+		}
+	}
+
+	cmd := exec.Command("make", wasmName) // #nosec
 	cmd.Dir = absPath
 
 	output, err := cmd.CombinedOutput()