Fix namespace qualification for core::string_view throughout codebase

Use fully qualified boost::core::string_view instead of core::string_view
or beast::string_view to ensure correct namespace resolution in nested
boost::beast namespace contexts. This fixes compilation errors across all
platforms where the compiler was looking for non-existent types like
boost::beast::core::string_view.

Fixes CI compilation failures in PR boostorg#3058.

Author: ssam18

example/doc/http_examples.hpp

@@ -376,7 +376,7 @@ response<empty_body>
 do_head_request(
     SyncStream& stream,
     DynamicBuffer& buffer,
-    core::string_view target,
+    boost::core::string_view target,
     error_code& ec)
 {
     // Do some type checking to be a good citizen
@@ -979,7 +979,7 @@ print_chunked_body(
     // after each chunk header and also after the last chunk.
     auto header_cb =
     [&](std::uint64_t size,               // Size of the chunk, or zero for the last chunk
-        core::string_view extensions,     // The raw chunk-extensions string. Already validated.
+        boost::core::string_view extensions,     // The raw chunk-extensions string. Already validated.
         error_code& ev)                   // We can set this to indicate an error
     {
         // Parse the chunk extensions so we can access them easily
@@ -1008,7 +1008,7 @@ print_chunked_body(
     // more times for each piece of a chunk body.
     auto body_cb =            
     [&](std::uint64_t remain,         // The number of bytes left in this chunk
-        core::string_view body,       // A buffer holding chunk body data
+        boost::core::string_view body,       // A buffer holding chunk body data
         error_code& ec)               // We can set this to indicate an error
     {
         // If this is the last piece of the chunk body,

include/boost/beast/_experimental/test/impl/stream.ipp

@@ -123,7 +123,7 @@ template<class Executor>
 basic_stream<Executor>::
 basic_stream(
     net::io_context& ioc,
-    core::string_view s)
+    boost::core::string_view s)
     : in_(detail::stream_service::make_impl(ioc.get_executor(), nullptr))
 {
     in_->b.commit(net::buffer_copy(
@@ -136,7 +136,7 @@ basic_stream<Executor>::
 basic_stream(
     net::io_context& ioc,
     fail_count& fc,
-    core::string_view s)
+    boost::core::string_view s)
     : in_(detail::stream_service::make_impl(ioc.get_executor(), &fc))
 {
     in_->b.commit(net::buffer_copy(
@@ -161,7 +161,7 @@ connect(basic_stream& remote)
 }
 
 template<class Executor>
-core::string_view
+boost::core::string_view
 basic_stream<Executor>::
 str() const
 {
@@ -175,7 +175,7 @@ str() const
 template<class Executor>
 void
 basic_stream<Executor>::
-append(core::string_view s)
+append(boost::core::string_view s)
 {
     std::lock_guard<std::mutex> lock{in_->m};
     in_->b.commit(net::buffer_copy(

include/boost/beast/_experimental/test/stream.hpp

@@ -281,7 +281,7 @@ class basic_stream
     */
     basic_stream(
         net::io_context& ioc,
-        core::string_view s);
+        boost::core::string_view s);
 
     /** Construct a stream
 
@@ -301,7 +301,7 @@ class basic_stream
     basic_stream(
         net::io_context& ioc,
         fail_count& fc,
-        core::string_view s);
+        boost::core::string_view s);
 
     /// Establish a connection
     void
@@ -333,12 +333,12 @@ class basic_stream
     }
 
     /// Returns a string view representing the pending input data
-    core::string_view
+    boost::core::string_view
     str() const;
 
     /// Appends a string to the pending input data
     void
-    append(core::string_view s);
+    append(boost::core::string_view s);
 
     /// Clear the pending input area
     void

include/boost/beast/core/detail/impl/temporary_buffer.ipp

@@ -23,15 +23,15 @@ namespace detail {
 
 void
 temporary_buffer::
-append(core::string_view s)
+append(boost::core::string_view s)
 {
     grow(s.size());
     unchecked_append(s);
 }
 
 void
 temporary_buffer::
-append(core::string_view s1, core::string_view s2)
+append(boost::core::string_view s1, boost::core::string_view s2)
 {
     grow(s1.size() + s2.size());
     unchecked_append(s1);
@@ -40,7 +40,7 @@ append(core::string_view s1, core::string_view s2)
 
 void
 temporary_buffer::
-unchecked_append(core::string_view s)
+unchecked_append(boost::core::string_view s)
 {
     auto n = s.size();
     std::memcpy(&data_[size_], s.data(), n);

include/boost/beast/core/detail/static_ostream.hpp

@@ -50,7 +50,7 @@ class static_ostream_buffer
     {
     }
 
-    core::string_view
+    boost::core::string_view
     str() const
     {
         if(! s_.empty())
@@ -128,7 +128,7 @@ class static_ostream : public std::basic_ostream<char>
         imbue(std::locale::classic());
     }
 
-    core::string_view
+    boost::core::string_view
     str() const
     {
         return osb_.str();

include/boost/beast/core/detail/string.hpp

@@ -22,10 +22,10 @@ namespace detail {
 namespace string_literals {
 
 inline
-core::string_view
+boost::core::string_view
 operator""_sv(char const* p, std::size_t n)
 {
-    return core::string_view{p, n};
+    return boost::core::string_view{p, n};
 }
 
 } // string_literals

include/boost/beast/core/detail/temporary_buffer.hpp

@@ -32,13 +32,13 @@ struct temporary_buffer
 
     BOOST_BEAST_DECL
     void
-    append(core::string_view s);
+    append(boost::core::string_view s);
 
     BOOST_BEAST_DECL
     void
-    append(core::string_view s1, core::string_view s2);
+    append(boost::core::string_view s1, boost::core::string_view s2);
 
-    core::string_view
+    boost::core::string_view
     view() const noexcept
     {
         return {data_, size_};
@@ -53,7 +53,7 @@ struct temporary_buffer
 private:
     BOOST_BEAST_DECL
     void
-    unchecked_append(core::string_view s);
+    unchecked_append(boost::core::string_view s);
 
     BOOST_BEAST_DECL
     void

include/boost/beast/core/impl/string.ipp

@@ -20,8 +20,8 @@ namespace beast {
 
 bool
 iequals(
-    beast::string_view lhs,
-    beast::string_view rhs)
+    boost::core::string_view lhs,
+    boost::core::string_view rhs)
 {
     if(lhs.size() != rhs.size())
         return false;
@@ -50,8 +50,8 @@ slow:
 
 bool
 iless::operator()(
-    core::string_view lhs,
-    core::string_view rhs) const
+    boost::core::string_view lhs,
+    boost::core::string_view rhs) const
 {
     using std::begin;
     using std::end;

include/boost/beast/core/impl/string_param.hpp

@@ -30,7 +30,7 @@ print(T const& t)
 template<class T>
 typename std::enable_if<
     ! std::is_integral<T>::value &&
-    ! std::is_convertible<T, core::string_view>::value
+    ! std::is_convertible<T, boost::core::string_view>::value
 >::type
 string_param::
 print(T const& t)
@@ -44,7 +44,7 @@ print(T const& t)
 inline
 void
 string_param::
-print(core::string_view sv)
+print(boost::core::string_view sv)
 {
     sv_ = sv;
 }
@@ -60,7 +60,7 @@ print_1(T const& t)
     auto const it = detail::raw_to_string<
         char, T, std::char_traits<char>>(
             last, sizeof(buf), t);
-    *os_ << core::string_view{it,
+    *os_ << boost::core::string_view{it,
         static_cast<std::size_t>(last - it)};
 }
 

include/boost/beast/core/string.hpp

@@ -27,24 +27,24 @@ namespace beast {
 BOOST_BEAST_DECL
 bool
 iequals(
-    beast::string_view lhs,
-    beast::string_view rhs);
+    boost::core::string_view lhs,
+    boost::core::string_view rhs);
 
 /** A case-insensitive less predicate for strings.
 
     The case-comparison operation is defined only for low-ASCII characters.
 
     As of C++14, containers using this class as the `Compare` type will take part
     in heterogeneous lookup if the search term is implicitly convertible to
-    @ref core::string_view.
+    @ref boost::core::string_view.
 */
 struct iless
 {
     BOOST_BEAST_DECL
     bool
     operator()(
-        core::string_view lhs,
-        core::string_view rhs) const;
+        boost::core::string_view lhs,
+        boost::core::string_view rhs) const;
 
     using is_transparent = void;
 };
@@ -55,14 +55,14 @@ struct iless
 
     As of C++14, containers using this class as the `Compare` type will take part
     in heterogeneous lookup if the search term is implicitly convertible to
-    @ref core::string_view.
+    @ref boost::core::string_view.
 */
 struct iequal
 {
     bool
     operator()(
-        core::string_view lhs,
-        core::string_view rhs) const
+        boost::core::string_view lhs,
+        boost::core::string_view rhs) const
     {
         return iequals(lhs, rhs);
     }