refactor(es/ast)!: use Function for object accessors

Author: magic-akari

.changeset/use-function-for-object-accessors.md

@@ -0,0 +1,28 @@
+---
+swc_core: major
+swc_ecma_ast: major
+swc_ecma_codegen: major
+swc_ecma_compat_common: major
+swc_ecma_compat_es2015: major
+swc_ecma_compat_es2022: major
+swc_ecma_lexer: major
+swc_ecma_lints: major
+swc_ecma_minifier: major
+swc_ecma_parser: major
+swc_ecma_quote_macros: major
+swc_ecma_react_compiler: major
+swc_ecma_transformer: major
+swc_ecma_transforms_base: major
+swc_ecma_transforms_classes: major
+swc_ecma_transforms_module: major
+swc_ecma_transforms_optimization: major
+swc_ecma_transforms_proposal: major
+swc_ecma_transforms_typescript: major
+swc_ecma_utils: major
+swc_ecma_visit: major
+swc_estree_compat: major
+swc_ts_fast_strip: major
+swc_typescript: major
+---
+
+refactor(es/ast)!: Use `Function` for object accessors

bindings/binding_core_wasm/src/types.rs

@@ -2297,18 +2297,13 @@ export interface AssignmentProperty extends Node {
 export interface GetterProperty extends PropBase, HasSpan {
   type: "GetterProperty";
 
-  typeAnnotation?: TsTypeAnnotation;
-
-  body?: BlockStatement;
+  function: Fn;
 }
 
 export interface SetterProperty extends PropBase, HasSpan {
   type: "SetterProperty";
 
-  thisParam?: Pattern;
-
-  param: Pattern;
-  body?: BlockStatement;
+  function: Fn;
 }
 
 export interface MethodProperty extends PropBase, Fn {

bindings/binding_minifier_wasm/src/types.rs

@@ -2194,18 +2194,13 @@ export interface AssignmentProperty extends Node {
 export interface GetterProperty extends PropBase, HasSpan {
   type: "GetterProperty";
 
-  typeAnnotation?: TsTypeAnnotation;
-
-  body?: BlockStatement;
+  function: Fn;
 }
 
 export interface SetterProperty extends PropBase, HasSpan {
   type: "SetterProperty";
 
-  thisParam?: Pattern;
-
-  param: Pattern;
-  body?: BlockStatement;
+  function: Fn;
 }
 
 export interface MethodProperty extends PropBase, Fn {

crates/swc/tests/fixture/issues-11xxx/11996-systemjs-export-setter-hygiene/output/index.js

@@ -1 +1 @@
-System.register([],function(e,t){"use strict";var r,s;var a={set a(_value){s=_value;e("a",s)}};e("a",void 0);return{setters:[],execute:function(){r=1;({a:a.a}=source)}}});
+System.register([],function(e,t){"use strict";var r,s;var a={set a(t){s=t;e("a",s)}};e("a",void 0);return{setters:[],execute:function(){r=1;({a:a.a}=source)}}});

crates/swc/tests/fixture/issues-8xxx/8148/output/input.js

@@ -2,12 +2,11 @@ function _toBeMocked() {
     return "I am the original function";
 }
 export var toBeMocked = _toBeMocked;
-var _$mock = {
+export var mock = {
     get toBeMocked () {
         return toBeMocked;
     },
     set toBeMocked (mock){
         toBeMocked = mock;
     }
 };
-export { _$mock as mock };

crates/swc/tests/tsc-references/accessorWithES5.1.normal.js

@@ -24,7 +24,7 @@ var D = /*#__PURE__*/ function() {
     _create_class(D, [
         {
             key: "x",
-            set: function set(v1) {}
+            set: function set(v) {}
         }
     ]);
     return D;

crates/swc/tests/tsc-references/computedPropertyNames11_ES6.1.normal.js

@@ -2,7 +2,7 @@
 var s;
 var n;
 var a;
-var v1 = {
+var v = {
     get [s] () {
         return 0;
     },

crates/swc/tests/tsc-references/computedPropertyNames1_ES6.1.normal.js

@@ -1,5 +1,5 @@
 //// [computedPropertyNames1_ES6.ts]
-var v1 = {
+var v = {
     get [0 + 1] () {
         return 0;
     },

crates/swc/tests/tsc-references/jsDeclarationsFunctionLikeClasses2.1.normal.js

@@ -31,13 +31,13 @@ Vec.prototype = {
 /**
  * @param {number} x
  * @param {number} y
- */ export function Point2D(x1, y1) {
+ */ export function Point2D(x, y) {
     if (!_instanceof(this, Point2D)) {
-        return new Point2D(x1, y1);
+        return new Point2D(x, y);
     }
     Vec.call(this, 2);
-    this.x = x1;
-    this.y = y1;
+    this.x = x;
+    this.y = y;
 }
 Point2D.prototype = {
     __proto__: Vec,

crates/swc/tests/tsc-references/jsDeclarationsFunctionLikeClasses2.2.minified.js

@@ -14,9 +14,9 @@ Vec.prototype = {
         return Math.sqrt(sum);
     }
 };
-export function Point2D(x1, y1) {
-    if (!_instanceof(this, Point2D)) return new Point2D(x1, y1);
-    Vec.call(this, 2), this.x = x1, this.y = y1;
+export function Point2D(x, y) {
+    if (!_instanceof(this, Point2D)) return new Point2D(x, y);
+    Vec.call(this, 2), this.x = x, this.y = y;
 }
 Point2D.prototype = {
     __proto__: Vec,