Skip to content

Commit c1f8d64

Browse files
authored
feat(oracle): enable ARM support (#466)
1 parent 292c93b commit c1f8d64

4 files changed

Lines changed: 2 additions & 6 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ jobs:
114114
tool: cargo-hack
115115
- name: Install Protoc # for pulsar tests
116116
uses: arduino/setup-protoc@v3
117-
- name: Install the latest Oracle instant client # for oracle tess
117+
- name: Install the latest Oracle instant client # for Oracle tests
118118
run: |
119119
sudo ln -s /usr/lib/x86_64-linux-gnu/libaio.so.1t64 /usr/lib/x86_64-linux-gnu/libaio.so.1
120120
curl -Lo basic.zip https://download.oracle.com/otn_software/linux/instantclient/instantclient-basic-linuxx64.zip

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ First of all, thank you for contributing to testcontainers-rs-modules-community.
2727
- Ensure you have an [up-to-date Rust toolchain](https://rustup.rs/), with `clippy` and `rustfmt` components installed
2828
- Install the [cargo-hack](https://github.com/taiki-e/cargo-hack) subcommand (recommended)
2929
- Fork this repository
30-
- Optionally, if you need to run `Oracle` tests, you must setup `Oracle Client`, as indicated in the documentation of the [Rust-oracle](https://docs.rs/oracle/latest/oracle/) crate (note that ARM architecture is not supported, as there is no Oracle Database Free port for ARM chips)
30+
- Optionally, if you need to run `Oracle` tests, you must setup `Oracle Client`, as indicated in the documentation of the [Rust-oracle](https://docs.rs/oracle/latest/oracle/) crate
3131

3232
### Working with existing modules
3333

src/oracle/free.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@ pub const FREE_PORT: ContainerPort = ContainerPort::Tcp(1521);
1919
///
2020
/// The default schema is `test`, with a password `test`.
2121
///
22-
/// NOTE: Currently, there is no Oracle Database Free port for ARM chips,
23-
/// hence Oracle Database Free images cannot run on the new Apple M chips via Docker Desktop.
24-
///
2522
/// # Example
2623
/// ```
2724
/// use std::time::Duration;

src/oracle/mod.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
1-
#[cfg(not(any(target_arch = "arm", target_arch = "aarch64")))]
21
/// **Oracle Database Free** (relational database) testcontainer
32
pub mod free;

0 commit comments

Comments
 (0)