Merge pull request #1243 from tsg-ut/feat/atcoder-problemset-achievements

AtCoder精進セット（EDPC/TDPC/Next DP/FPS24）の全完実績を追加

Author: ZenReKkyo

achievements/achievements.ts

@@ -1824,6 +1824,60 @@ const achievements: Achievement[] = [
 		counter: 'atcoder-typical-solves',
 		value: 100,
 	},
+	{
+		id: 'atcoder-fps24-solves-21',
+		difficulty: 'hard',
+		title: 'FPSが得意な人',
+		condition: 'FPS24題の問題を21問以上ACする',
+		category: 'atcoder',
+		counter: 'atcoder-fps24-solves',
+		value: 21,
+	},
+	{
+		id: 'atcoder-fps24-solves-24',
+		difficulty: 'professional',
+		title: 'HoMaMaOvO',
+		condition: 'FPS24題の全問題をACする',
+		category: 'atcoder',
+		counter: 'atcoder-fps24-solves',
+		value: 24,
+	},
+	{
+		id: 'atcoder-tdpc-solves-20',
+		difficulty: 'hard',
+		title: 'DPに慣れている人',
+		condition: 'Typical DP Contestの全問題をACする',
+		category: 'atcoder',
+		counter: 'atcoder-tdpc-solves',
+		value: 20,
+	},
+	{
+		id: 'atcoder-edpc-solves-26',
+		difficulty: 'hard',
+		title: 'EDPCを全問解ける人',
+		condition: 'Educational DP Contestの全問題をACする',
+		category: 'atcoder',
+		counter: 'atcoder-edpc-solves',
+		value: 26,
+	},
+	{
+		id: 'atcoder-ndpc-solves-18',
+		difficulty: 'hard',
+		title: 'DP完全理解者',
+		condition: 'Next DP Contestの問題を18問以上ACする',
+		category: 'atcoder',
+		counter: 'atcoder-ndpc-solves',
+		value: 18,
+	},
+	{
+		id: 'atcoder-ndpc-solves-20',
+		difficulty: 'professional',
+		title: 'チーム参加したHoMaMaOvO(注：結託は禁止です)',
+		condition: 'Next DP Contestの全問題をACする',
+		category: 'atcoder',
+		counter: 'atcoder-ndpc-solves',
+		value: 20,
+	},
 
 	// pwnyaa
 

atcoder/index.ts

@@ -15,7 +15,7 @@ import {getMemberIcon, getMemberName} from '../lib/slackUtils';
 import State from '../lib/state';
 // eslint-disable-next-line no-unused-vars
 import type {Results, Standings} from './types';
-import {fetchUserACsInContest} from './utils';
+import {fetchUserACsInContests} from './utils';
 
 const log = logger.child({bot: 'atcoder'});
 const mutex = new Mutex();
@@ -114,6 +114,15 @@ interface ContestEntry {
 const SILENT_CONTEST_PREFIXES = ['awc', 'adt_'];
 const SILENT_START_CONTEST_PREFIXES = ['adt_'];
 
+// AtCoder problem sets whose solve counts unlock completion achievements.
+// contestId is the AtCoder Problems contest id; counter matches an achievement in achievements.ts.
+const PROBLEM_SET_COUNTERS: {contestId: string, counter: string}[] = [
+	{contestId: 'fps-24', counter: 'atcoder-fps24-solves'},
+	{contestId: 'tdpc', counter: 'atcoder-tdpc-solves'},
+	{contestId: 'dp', counter: 'atcoder-edpc-solves'},
+	{contestId: 'ndpc', counter: 'atcoder-ndpc-solves'},
+];
+
 export default async ({eventClient, webClient: slack}: SlackInterface) => {
 	const state = await State.init<StateObj>('atcoder', {
 		users: [],
@@ -493,15 +502,26 @@ export default async ({eventClient, webClient: slack}: SlackInterface) => {
 			await new Promise<void>((resolve) => {
 				setTimeout(resolve, 1000);
 			});
-			const absACs = await fetchUserACsInContest(user.atcoder, 'abs');
+			// abs / typical90 are fetched alongside the completion sets but kept out of
+			// PROBLEM_SET_COUNTERS because they don't map 1:1 to a counter
+			// (atcoder-typical-solves counts abs + typical90 combined).
+			const acsByContest = await fetchUserACsInContests(user.atcoder, [
+				'abs',
+				'typical90',
+				...PROBLEM_SET_COUNTERS.map(({contestId}) => contestId),
+			]).catch((error: unknown): null => {
+				log.error(`[atcoder-daily] Failed to fetch submissions for ${user.atcoder}: ${String(error)}`);
+				return null;
+			});
+			// Skip this user for today's run if their submissions could not be fetched
+			if (acsByContest === null) {
+				continue;
+			}
+
+			const absACs = acsByContest.get('abs') ?? new Set<string>();
 			absACs.delete('practice_1');
 			const absSolve = absACs.size;
-
-			await new Promise<void>((resolve) => {
-				setTimeout(resolve, 1000);
-			});
-			const typicalACs = await fetchUserACsInContest(user.atcoder, 'typical90');
-			const typicalSolve = typicalACs.size;
+			const typicalSolve = acsByContest.get('typical90')?.size ?? 0;
 
 			const previousAbsSolve = (await get(user.slack, 'atcoder-abs-solves')) || 0;
 			if (typeof previousAbsSolve !== 'number') {
@@ -513,12 +533,17 @@ export default async ({eventClient, webClient: slack}: SlackInterface) => {
 			}
 			const previousTypicalSolve = previousTypicalSolves - previousAbsSolve;
 
-			set(user.slack, 'atcoder-abs-solves', absSolve);
-			set(user.slack, 'atcoder-typical-solves', absSolve + typicalSolve);
+			await set(user.slack, 'atcoder-abs-solves', absSolve);
+			await set(user.slack, 'atcoder-typical-solves', absSolve + typicalSolve);
 
 			increase += Math.max(0, absSolve - previousAbsSolve);
 			increase += Math.max(0, typicalSolve - previousTypicalSolve);
 
+			// Unlock completion achievements for well-known problem sets (EDPC, TDPC, etc.)
+			for (const {contestId, counter} of PROBLEM_SET_COUNTERS) {
+				await set(user.slack, counter, acsByContest.get(contestId)?.size ?? 0);
+			}
+
 			let username = await getMemberName(user.slack);
 			if (username.length > 12) {
 				username = `${username.slice(0, 10)}...`;

atcoder/utils.ts

@@ -32,7 +32,7 @@ const getStorage = (): Promise<nodePersist.LocalStorage> => {
 	return storagePromise;
 };
 
-export const fetchUserACsInContest = async (userId: string, contestId: string): Promise<Set<string>> => {
+const syncUserSubmissions = async (userId: string): Promise<UserSubmissionCache> => {
 	const storage = await getStorage();
 
 	const cacheKey = `submissions-${userId}`;
@@ -77,5 +77,12 @@ export const fetchUserACsInContest = async (userId: string, contestId: string):
 	cached.lastFetchedSecond = maxEpochSecond;
 	await storage.setItem(cacheKey, cached);
 
-	return new Set(cached.acsByContest[contestId] ?? []);
+	return cached;
+};
+
+// Sync a user's submissions once and return the AC sets for multiple contests,
+// avoiding a separate API round-trip (and throttling delay) per contest.
+export const fetchUserACsInContests = async (userId: string, contestIds: string[]): Promise<Map<string, Set<string>>> => {
+	const cached = await syncUserSubmissions(userId);
+	return new Map(contestIds.map((contestId) => [contestId, new Set(cached.acsByContest[contestId] ?? [])]));
 };