Skip to content

Commit 0893c7d

Browse files
committed
fix: use dialog-card-sm class instead of inline px in dialog shell
DESIGN.md requires rem and forbids inline styles; EffortDialogShell used an inline px max-width. Switch to the existing dialog-card-sm class (31.25rem / 500px) and drop the maxWidth prop, standardizing the effort dialogs on the design-system size. Addresses CodeRabbit review on #228.
1 parent 323aa41 commit 0893c7d

3 files changed

Lines changed: 9 additions & 14 deletions

File tree

VueApp/src/Effort/components/EffortDialogShell.vue

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
:aria-labelledby="titleId"
66
@keydown.escape="$emit('close')"
77
>
8-
<q-card :style="{ width: '100%', maxWidth: `${maxWidth}px` }">
8+
<q-card class="dialog-card-sm">
99
<q-card-section class="row items-center q-pb-none">
1010
<div
1111
:id="titleId"
@@ -48,19 +48,16 @@
4848
import { ref } from "vue"
4949
import type { QForm } from "quasar"
5050
import DialogSubmitActions from "./DialogSubmitActions.vue"
51+
import "../effort-dialogs.css"
5152
import "../effort-forms.css"
5253
53-
withDefaults(
54-
defineProps<{
55-
modelValue: boolean
56-
title: string
57-
titleId: string
58-
submitLabel: string
59-
isSaving: boolean
60-
maxWidth?: number
61-
}>(),
62-
{ maxWidth: 550 },
63-
)
54+
defineProps<{
55+
modelValue: boolean
56+
title: string
57+
titleId: string
58+
submitLabel: string
59+
isSaving: boolean
60+
}>()
6461
6562
defineEmits<{
6663
close: []

VueApp/src/Effort/components/EffortRecordAddDialog.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
title="Add Effort Record"
66
title-id="effort-record-add-title"
77
submit-label="Add Effort"
8-
:max-width="500"
98
:is-saving="isSaving"
109
@close="handleClose"
1110
@submit="createRecord"

VueApp/src/Effort/components/EffortRecordEditDialog.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
title="Edit Effort Record"
66
title-id="effort-record-edit-title"
77
submit-label="Save"
8-
:max-width="500"
98
:is-saving="isSaving"
109
@close="handleClose"
1110
@submit="updateRecord"

0 commit comments

Comments
 (0)