cp: remove feat_acl & replace exacl by xattr

Author: oech3

Cargo.lock

@@ -74,11 +74,6 @@ feat_systemd_logind = [
   "uucore/feat_systemd_logind",
   "who/feat_systemd_logind",
 ]
-# "feat_acl" == enable support for ACLs (access control lists; by using`--features feat_acl`)
-# NOTE:
-# * On linux, the posix-acl/acl-sys crate requires `libacl` headers and shared library to be accessible in the C toolchain at compile time.
-# * On FreeBSD and macOS this is not required.
-feat_acl = ["cp/feat_acl"]
 # "feat_selinux" == enable support for SELinux Security Context (by using `--features feat_selinux`)
 # NOTE:
 # * The selinux(-sys) crate requires `libselinux` headers and shared library to be accessible in the C toolchain at compile time.

Cargo.toml

@@ -44,8 +44,8 @@ rustix = { workspace = true }
 selinux = { workspace = true, optional = true }
 
 [target.'cfg(unix)'.dependencies]
-exacl = { workspace = true, optional = true }
 nix = { workspace = true, features = ["fs"] }
+xattr = { workspace = true }
 
 [target.'cfg(target_os = "windows")'.dependencies]
 windows-sys = { workspace = true, features = [
@@ -68,4 +68,3 @@ harness = false
 
 [features]
 feat_selinux = ["selinux", "uucore/selinux"]
-feat_acl = ["exacl"]

src/uu/cp/Cargo.toml

@@ -1883,11 +1883,14 @@ pub(crate) fn copy_attributes(
 
             fs::set_permissions(dest, source_perms)
                 .map_err(|e| CpError::IoErrContext(e, context.to_owned()))?;
-            // FIXME: Implement this for windows as well
-            #[cfg(feature = "feat_acl")]
-            exacl::getfacl(source, None)
-                .and_then(|acl| exacl::setfacl(&[dest], &acl, None))
-                .map_err(|err| CpError::Error(err.to_string()))?;
+            #[cfg(any(target_os = "freebsd", target_os = "linux", target_vendor = "apple"))]
+            // exacl supports them at least for. todo: support acl for other targets
+            if let Some(acl) = xattr::get(source, "system.posix_acl_access")
+                .map_err(|e| CpError::Error(e.to_string()))?
+            {
+                xattr::set(dest, "system.posix_acl_access", &acl)
+                    .map_err(|e| CpError::Error(e.to_string()))?;
+            }
             // GNU `cp -p` preserves POSIX ACLs as part of mode. On Linux the
             // ACLs are stored as `system.posix_acl_*` xattrs; copy just those
             // so we keep ACL parity with GNU without preserving user xattrs