Fix Bun test defaults (#1860)

Author: jakeleventhal

packages/knip/fixtures/plugins/bun6/index.test.ts

@@ -0,0 +1 @@
+import './index.ts';

packages/knip/fixtures/plugins/bun6/index.ts

@@ -0,0 +1 @@
+

packages/knip/fixtures/plugins/bun6/package.json

@@ -0,0 +1,6 @@
+{
+  "name": "@plugins/bun6",
+  "scripts": {
+    "test": "bun --config=\"$(git rev-parse --show-toplevel)/bunfig.toml\" test"
+  }
+}

packages/knip/fixtures/plugins/bun7/bun.lock

@@ -0,0 +1 @@
+import './index.ts';

packages/knip/fixtures/plugins/bun7/index.test.ts

@@ -0,0 +1 @@
+

packages/knip/fixtures/plugins/bun7/index.ts

@@ -0,0 +1,6 @@
+{
+  "name": "@plugins/bun7",
+  "devDependencies": {
+    "bun": "*"
+  }
+}

packages/knip/fixtures/plugins/bun7/package.json

@@ -1,18 +1,29 @@
 import parseArgs from '../../util/parse-args.ts';
 import type { IsPluginEnabled, Plugin, Resolve, ResolveConfig } from '../../types/config.ts';
-import { toDeferResolve, toEntry } from '../../util/input.ts';
+import { isFile } from '../../util/fs.ts';
+import { toDeferResolve, toEntry, toIgnore } from '../../util/input.ts';
 import type { BunfigConfig } from './types.ts';
 
 // https://bun.sh/docs/cli/test
 
 const title = 'Bun';
 
-const enablers = ['bun'];
+const enablers =
+  'This plugin is enabled when a `bun.lock` or `bun.lockb` file is found or a `bun test` script is configured.';
+
+const getBunTestArgs = (script: string) => {
+  const args = script.split(/\s+/);
+  const bunIndex = args.indexOf('bun');
+  const testIndex = bunIndex === -1 ? -1 : args.indexOf('test', bunIndex + 1);
+  if (args.slice(bunIndex + 1, testIndex).includes('run')) return;
+  return testIndex === -1 ? undefined : args.slice(testIndex + 1);
+};
 
 const hasBunTest = (scripts: Record<string, string> | undefined) =>
-  scripts && Object.values(scripts).some(script => /(?<=^|\s)bun test/.test(script));
+  scripts && Object.values(scripts).some(script => typeof script === 'string' && getBunTestArgs(script));
 
-const isEnabled: IsPluginEnabled = ({ manifest }) => !!hasBunTest(manifest.scripts);
+const isEnabled: IsPluginEnabled = ({ cwd, manifest }) =>
+  isFile(cwd, 'bun.lock') || isFile(cwd, 'bun.lockb') || !!hasBunTest(manifest.scripts);
 
 const config = ['bunfig.toml'];
 
@@ -33,15 +44,19 @@ const toPatterns = (arg: string) => {
 const resolve: Resolve = options => {
   const scripts = { ...options.rootManifest?.scripts, ...options.manifest.scripts };
   for (const script of Object.values(scripts)) {
-    if (/(?<=^|\s)bun test/.test(script)) {
-      const parsed = parseArgs(script.split(' '), { string: ['timeout', 'rerun-each', 'preload'] });
-      const args = parsed._.filter(id => id !== 'bun' && id !== 'test');
-      const inputs = (args.length === 0 ? patterns : args.flatMap(toPatterns)).map(toEntry);
+    const bunTestArgs = getBunTestArgs(script);
+    if (bunTestArgs) {
+      const parsed = parseArgs(bunTestArgs, { string: ['timeout', 'rerun-each', 'preload'] });
+      const args = parsed._;
+      const inputs = [
+        toIgnore('bun', 'dependencies'),
+        ...(args.length === 0 ? patterns : args.flatMap(toPatterns)).map(toEntry),
+      ];
       for (const specifier of [parsed.preload ?? []].flat()) inputs.push(toDeferResolve(specifier));
       return inputs;
     }
   }
-  return [];
+  return [toIgnore('bun', 'dependencies'), ...patterns.map(toEntry)];
 };
 
 const plugin: Plugin = {

packages/knip/src/plugins/bun/index.ts

@@ -0,0 +1,19 @@
+import assert from 'node:assert/strict';
+import test from 'node:test';
+import { main } from '../../src/index.ts';
+import baseCounters from '../helpers/baseCounters.ts';
+import { createOptions } from '../helpers/create-options.ts';
+import { resolve } from '../helpers/resolve.ts';
+
+const cwd = resolve('fixtures/plugins/bun6');
+
+test('Find dependencies with the Bun plugin (options before test)', async () => {
+  const options = await createOptions({ cwd });
+  const { counters } = await main(options);
+
+  assert.deepEqual(counters, {
+    ...baseCounters,
+    processed: 2,
+    total: 2,
+  });
+});

packages/knip/test/plugins/bun6.test.ts

@@ -0,0 +1,19 @@
+import assert from 'node:assert/strict';
+import test from 'node:test';
+import { main } from '../../src/index.ts';
+import baseCounters from '../helpers/baseCounters.ts';
+import { createOptions } from '../helpers/create-options.ts';
+import { resolve } from '../helpers/resolve.ts';
+
+const cwd = resolve('fixtures/plugins/bun7');
+
+test('Find dependencies with the Bun plugin (lockfile only)', async () => {
+  const options = await createOptions({ cwd });
+  const { counters } = await main(options);
+
+  assert.deepEqual(counters, {
+    ...baseCounters,
+    processed: 2,
+    total: 2,
+  });
+});