Refine eve subagent entries

jakeleventhal · jakeleventhal · commit 56b27db13408 · 2026-07-06T18:05:41.000-04:00
diff --git a/packages/knip/fixtures/plugins/eve/agent/instructions.ts b/packages/knip/fixtures/plugins/eve/agent/instructions.ts
@@ -0,0 +1 @@
+export default 'Use concise answers.';
diff --git a/packages/knip/fixtures/plugins/eve/agent/instrumentation.ts b/packages/knip/fixtures/plugins/eve/agent/instrumentation.ts
@@ -0,0 +1,5 @@
+import { defineInstrumentation } from 'eve/instrumentation';
+
+export default defineInstrumentation({
+  functionId: 'eve-fixture',
+});
diff --git a/packages/knip/fixtures/plugins/eve/agent/skills/summarize.ts b/packages/knip/fixtures/plugins/eve/agent/skills/summarize.ts
@@ -0,0 +1,6 @@
+import { defineSkill } from 'eve/skills';
+
+export default defineSkill({
+  description: 'Summarize weather data.',
+  run: () => 'Sunny',
+});
diff --git a/packages/knip/fixtures/plugins/eve/agent/subagents/researcher/channels/slack.ts b/packages/knip/fixtures/plugins/eve/agent/subagents/researcher/channels/slack.ts
@@ -0,0 +1 @@
+export default {};
diff --git a/packages/knip/fixtures/plugins/eve/agent/subagents/researcher/connections/search.ts b/packages/knip/fixtures/plugins/eve/agent/subagents/researcher/connections/search.ts
@@ -0,0 +1,4 @@
+import { connectionConfig } from 'connection-config';
+import { defineMcpClientConnection } from 'eve/connections';
+
+export default defineMcpClientConnection(connectionConfig());
diff --git a/packages/knip/fixtures/plugins/eve/agent/subagents/researcher/hooks/log.ts b/packages/knip/fixtures/plugins/eve/agent/subagents/researcher/hooks/log.ts
@@ -0,0 +1,6 @@
+import { defineHook } from 'eve/hooks';
+import { hookLogger } from 'hook-logger';
+
+export default defineHook({
+  onEvent: event => hookLogger(event),
+});
diff --git a/packages/knip/fixtures/plugins/eve/agent/subagents/researcher/instructions.ts b/packages/knip/fixtures/plugins/eve/agent/subagents/researcher/instructions.ts
@@ -0,0 +1 @@
+export default 'Research the weather first.';
diff --git a/packages/knip/fixtures/plugins/eve/agent/subagents/researcher/instrumentation.ts b/packages/knip/fixtures/plugins/eve/agent/subagents/researcher/instrumentation.ts
@@ -0,0 +1 @@
+export default {};
diff --git a/packages/knip/fixtures/plugins/eve/agent/subagents/researcher/sandbox/sandbox.ts b/packages/knip/fixtures/plugins/eve/agent/subagents/researcher/sandbox/sandbox.ts
@@ -0,0 +1,5 @@
+import { defineSandbox } from 'eve/sandbox';
+
+export default defineSandbox({
+  workdir: '/workspace',
+});
diff --git a/packages/knip/fixtures/plugins/eve/agent/subagents/researcher/schedules/daily.ts b/packages/knip/fixtures/plugins/eve/agent/subagents/researcher/schedules/daily.ts
@@ -0,0 +1 @@
+export default {};
diff --git a/packages/knip/fixtures/plugins/eve/agent/subagents/researcher/skills/summarize.ts b/packages/knip/fixtures/plugins/eve/agent/subagents/researcher/skills/summarize.ts
@@ -0,0 +1,6 @@
+import { defineSkill } from 'eve/skills';
+
+export default defineSkill({
+  description: 'Summarize research results.',
+  run: () => 'Research complete',
+});
diff --git a/packages/knip/src/plugins/eve/index.ts b/packages/knip/src/plugins/eve/index.ts
@@ -11,13 +11,15 @@ const isEnabled: IsPluginEnabled = ({ dependencies }) => hasDependency(dependenc
 
 const extensions = '{js,jsx,ts,tsx,mjs,cjs,mts,cts}';
 
-const agentFileNames = '{agent,instructions,instrumentation,sandbox}';
+const rootAgentFileNames = '{agent,instructions,instrumentation,sandbox}';
+
+const subagentFileNames = '{agent,instructions,sandbox}';
 
 const production = [
-  `{,agent/}${agentFileNames}.${extensions}`,
+  `{,agent/}${rootAgentFileNames}.${extensions}`,
   `{,agent/}sandbox/sandbox.${extensions}`,
   `{,agent/}{channels,connections,hooks,skills,tools,schedules}/**/*.${extensions}`,
-  `{,agent/}subagents/**/${agentFileNames}.${extensions}`,
+  `{,agent/}subagents/**/${subagentFileNames}.${extensions}`,
   `{,agent/}subagents/**/sandbox/sandbox.${extensions}`,
   `{,agent/}subagents/**/{connections,hooks,skills,tools}/**/*.${extensions}`,
 ];
diff --git a/packages/knip/test/plugins/eve.test.ts b/packages/knip/test/plugins/eve.test.ts
@@ -12,9 +12,20 @@ test('Find dependencies with the eve plugin', async () => {
   const { counters, issues } = await main(options);
 
   assert('agent/lib/unused.ts' in issues.files);
+  assert('agent/subagents/researcher/channels/slack.ts' in issues.files);
+  assert('agent/subagents/researcher/instrumentation.ts' in issues.files);
+  assert('agent/subagents/researcher/schedules/daily.ts' in issues.files);
+  assert(!('agent/instructions.ts' in issues.files));
+  assert(!('agent/instrumentation.ts' in issues.files));
+  assert(!('agent/skills/summarize.ts' in issues.files));
   assert(!('agent/tools/get_weather.ts' in issues.files));
   assert(!('agent/channels/slack.ts' in issues.files));
   assert(!('agent/connections/search.ts' in issues.files));
+  assert(!('agent/subagents/researcher/connections/search.ts' in issues.files));
+  assert(!('agent/subagents/researcher/hooks/log.ts' in issues.files));
+  assert(!('agent/subagents/researcher/instructions.ts' in issues.files));
+  assert(!('agent/subagents/researcher/sandbox/sandbox.ts' in issues.files));
+  assert(!('agent/subagents/researcher/skills/summarize.ts' in issues.files));
   assert(!('agent/subagents/researcher/tools/search.ts' in issues.files));
   assert(!issues.exports['agent/lib/weather.ts']?.getWeather);
   assert(!issues.dependencies['package.json']?.eve);
@@ -23,8 +34,8 @@ test('Find dependencies with the eve plugin', async () => {
 
   assert.deepEqual(counters, {
     ...baseCounters,
-    files: 1,
-    processed: 11,
-    total: 11,
+    files: 4,
+    processed: 22,
+    total: 22,
   });
 });

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+export default 'Research the weather first.';`