Resolve #-imports to source when node condition is unbuilt (resolve #1873)

Author: webpro

packages/knip/fixtures/resolution/subpath-import/.gitignore

@@ -0,0 +1 @@
+dist

packages/knip/fixtures/resolution/subpath-import/entry.ts

@@ -1,2 +1,4 @@
 import dep from '#dep';
+import builtless from '#builtless';
 dep;
+builtless;

packages/knip/fixtures/resolution/subpath-import/lib/builtless.ts

@@ -0,0 +1 @@
+export default 'builtless';

packages/knip/fixtures/resolution/subpath-import/package.json

@@ -4,6 +4,10 @@
     "#dep": {
       "node": "dep-node-native",
       "default": "./lib/dep-polyfill.js"
+    },
+    "#builtless": {
+      "node": "./dist/builtless.js",
+      "default": "./lib/builtless.ts"
     }
   },
   "dependencies": {

packages/knip/fixtures/resolution/subpath-patterns/package.json

@@ -4,6 +4,10 @@
     "#internals/*": "./src/internals/*.ts",
     "#internals-explicit-ext/*": "./src/internals/*",
     "#internals-alias/used.alt": "./src/internals/used.alt",
-    "#:/*": "./src/internals/*.ts"
+    "#:/*": "./src/internals/*.ts",
+    "#conditional/*": {
+      "node": "./dist/*.js",
+      "browser": "./src/internals/*.ts"
+    }
   }
 }

packages/knip/fixtures/resolution/subpath-patterns/src/entry.ts

@@ -1,6 +1,8 @@
 import used from '#internals/used';
 import colon from '#:/colon';
+import conditional from '#conditional/conditional';
 import '#internals-explicit-ext/used.ext';
 import '#internals-alias/used.alt';
 used;
 colon;
+conditional;

packages/knip/fixtures/resolution/subpath-patterns/src/internals/conditional.ts

@@ -0,0 +1 @@
+export default 'conditional';

packages/knip/src/util/resolve.ts

@@ -23,7 +23,10 @@ const createSyncModuleResolver = (extensions: string[], tsConfigFile?: string) =
     tsconfig: tsConfigFile ? { configFile: tsConfigFile, references: 'auto' } : 'auto',
     ...baseOptions,
   });
-  const fallbackResolver = new ResolverFactory(baseOptions);
+  const fallbackResolver = new ResolverFactory({
+    ...baseOptions,
+    conditionNames: ['require', 'import', 'browser', 'default'],
+  });
 
   resolverInstances.push(resolver, fallbackResolver);
 

packages/knip/test/resolution/subpath-import.test.ts

@@ -15,8 +15,8 @@ test('Allows subpath-imports', async () => {
 
   assert.deepEqual(counters, {
     ...baseCounters,
-    processed: 3,
-    total: 3,
+    processed: 4,
+    total: 4,
   });
 });
 
@@ -27,8 +27,8 @@ test('Allows subpath-imports (production)', async () => {
 
   assert.deepEqual(counters, {
     ...baseCounters,
-    processed: 3,
-    total: 3,
+    processed: 4,
+    total: 4,
   });
 });
 
@@ -37,7 +37,7 @@ test('Allows subpath-imports (strict)', async () => {
   const { counters } = await main(options);
   assert.deepEqual(counters, {
     ...baseCounters,
-    processed: 3,
-    total: 3,
+    processed: 4,
+    total: 4,
   });
 });

packages/knip/test/resolution/subpath-patterns.test.ts

@@ -16,8 +16,8 @@ test('Allows subpath-patterns', async () => {
   assert.deepEqual(counters, {
     ...baseCounters,
     files: 1,
-    processed: 4,
-    total: 4,
+    processed: 5,
+    total: 5,
   });
 });
 
@@ -30,8 +30,8 @@ test('Allows subpath-patterns (production)', async () => {
   assert.deepEqual(counters, {
     ...baseCounters,
     files: 1,
-    processed: 4,
-    total: 4,
+    processed: 5,
+    total: 5,
   });
 });
 
@@ -44,7 +44,7 @@ test('Allows subpath-patterns (strict)', async () => {
   assert.deepEqual(counters, {
     ...baseCounters,
     files: 1,
-    processed: 4,
-    total: 4,
+    processed: 5,
+    total: 5,
   });
 });