Skip to content
This repository was archived by the owner on Jan 21, 2020. It is now read-only.

Commit 7c164ef

Browse files
committed
Merge branch 'hotfix/150'
Close #150
2 parents 2fde180 + 16c73d0 commit 7c164ef

10 files changed

Lines changed: 27 additions & 14 deletions

src/Collection.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
namespace ZF\Hal;
88

99
use Traversable;
10+
use Zend\Paginator\Paginator;
1011
use Zend\Stdlib\ArrayUtils;
1112

1213
/**
@@ -24,7 +25,7 @@ class Collection implements Link\LinkCollectionAwareInterface
2425
protected $attributes = [];
2526

2627
/**
27-
* @var array|Traversable|\Zend\Paginator\Paginator
28+
* @var array|Traversable|Paginator
2829
*/
2930
protected $collection;
3031

@@ -99,7 +100,7 @@ class Collection implements Link\LinkCollectionAwareInterface
99100
protected $entityRouteParams = [];
100101

101102
/**
102-
* @param array|Traversable|\Zend\Paginator\Paginator $collection
103+
* @param array|Traversable|Paginator $collection
103104
* @param string $entityRoute
104105
* @param array|Traversable $entityRouteParams
105106
* @param array|Traversable $entityRouteOptions
@@ -491,7 +492,7 @@ public function getAttributes()
491492
/**
492493
* Collection
493494
*
494-
* @return array|Traversable|\Zend\Paginator\Paginator
495+
* @return array|Traversable|Paginator
495496
*/
496497
public function getCollection()
497498
{

src/Factory/HalViewHelperFactory.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
namespace ZF\Hal\Factory;
88

99
use Interop\Container\ContainerInterface;
10+
use Zend\Hydrator\HydratorInterface;
11+
use Zend\Hydrator\HydratorPluginManager;
1012
use Zend\ServiceManager\AbstractPluginManager;
1113
use ZF\Hal\Exception;
1214
use ZF\Hal\Extractor\LinkCollectionExtractor;
@@ -28,6 +30,8 @@ public function __invoke(ContainerInterface $container)
2830
/* @var $rendererOptions \ZF\Hal\RendererOptions */
2931
$rendererOptions = $container->get('ZF\Hal\RendererOptions');
3032
$metadataMap = $container->get('ZF\Hal\MetadataMap');
33+
34+
/** @var HydratorPluginManager $hydrators */
3135
$hydrators = $metadataMap->getHydratorManager();
3236

3337
$helper = new Plugin\Hal($hydrators);
@@ -48,6 +52,7 @@ public function __invoke(ContainerInterface $container)
4852
));
4953
}
5054

55+
/** @var HydratorInterface $hydrator */
5156
$hydrator = $hydrators->get($defaultHydrator);
5257
$helper->setDefaultHydrator($hydrator);
5358
}

src/Factory/LinkUrlBuilderFactory.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
namespace ZF\Hal\Factory;
88

9+
use Zend\View\Helper\ServerUrl;
910
use ZF\Hal\Link\LinkUrlBuilder;
1011

1112
class LinkUrlBuilderFactory
@@ -20,6 +21,7 @@ public function __invoke($container)
2021

2122
$viewHelperManager = $container->get('ViewHelperManager');
2223

24+
/** @var ServerUrl $serverUrlHelper */
2325
$serverUrlHelper = $viewHelperManager->get('ServerUrl');
2426
if (isset($halConfig['options']['use_proxy'])) {
2527
$serverUrlHelper->setUseProxy($halConfig['options']['use_proxy']);

src/Link/PaginationInjectorInterface.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
namespace ZF\Hal\Link;
88

9+
use ZF\ApiProblem\ApiProblem;
910
use ZF\Hal\Collection;
1011

1112
interface PaginationInjectorInterface

src/Link/SelfLinkInjector.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
namespace ZF\Hal\Link;
88

9-
use ZF\Hal\Link\LinkCollectionAwareInterface;
109
use ZF\Hal\Collection;
1110
use ZF\Hal\Entity;
1211

src/Link/SelfLinkInjectorInterface.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66

77
namespace ZF\Hal\Link;
88

9-
use ZF\Hal\Link\LinkCollectionAwareInterface;
10-
119
interface SelfLinkInjectorInterface
1210
{
1311
/**

src/Module.php

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
namespace ZF\Hal;
88

9+
use Zend\Mvc\ApplicationInterface;
910
use Zend\Mvc\MvcEvent;
1011
use ZF\Hal\View\HalJsonStrategy;
1112

@@ -30,7 +31,9 @@ public function getConfig()
3031
*/
3132
public function onBootstrap(MvcEvent $e)
3233
{
33-
$events = $e->getTarget()->getEventManager();
34+
/** @var ApplicationInterface $application */
35+
$application = $e->getTarget();
36+
$events = $application->getEventManager();
3437
$events->attach(MvcEvent::EVENT_RENDER, [$this, 'onRender'], 100);
3538
}
3639

@@ -48,11 +51,14 @@ public function onRender(MvcEvent $e)
4851
return;
4952
}
5053

51-
$services = $e->getTarget()->getServiceManager();
54+
/** @var Application $application */
55+
$application = $e->getTarget();
56+
$services = $application->getServiceManager();
5257
$events = $services->get('View')->getEventManager();
5358

5459
// register at high priority, to "beat" normal json strategy registered
5560
// via view manager
61+
/** @var HalJsonStrategy $halStrategy */
5662
$halStrategy = $services->get('ZF\Hal\JsonStrategy');
5763
$halStrategy->attach($events, 200);
5864
}

src/Plugin/Hal.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
use ArrayObject;
1010
use Countable;
11+
use Traversable;
1112
use Zend\EventManager\Event;
1213
use Zend\EventManager\EventInterface;
1314
use Zend\EventManager\EventManagerAwareInterface;
@@ -941,7 +942,7 @@ public function createCollection($collection, $route = null)
941942
}
942943

943944
/**
944-
* @param object $object
945+
* @param array|Traversable|Paginator $object
945946
* @param Metadata $metadata
946947
* @return Collection
947948
*/

src/RendererOptions.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public function setHydrators(array $hydrators)
8787
}
8888

8989
/**
90-
* @return string
90+
* @return array
9191
*/
9292
public function getHydrators()
9393
{

src/ResourceFactory.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
namespace ZF\Hal;
88

99
use Closure;
10-
use ZF\Hal\Collection;
11-
use ZF\Hal\Entity;
10+
use Traversable;
11+
use Zend\Paginator\Paginator;
1212
use ZF\Hal\Extractor\EntityExtractor;
1313
use ZF\Hal\Exception;
1414
use ZF\Hal\Link\Link;
@@ -40,7 +40,7 @@ public function __construct(EntityHydratorManager $entityHydratorManager, Entity
4040
/**
4141
* Create a entity and/or collection based on a metadata map
4242
*
43-
* @param object $object
43+
* @param object|array|Traversable|Paginator $object
4444
* @param Metadata $metadata
4545
* @param bool $renderEmbeddedEntities
4646
* @return Entity|Collection
@@ -89,7 +89,7 @@ public function createEntityFromMetadata($object, Metadata $metadata, $renderEmb
8989
}
9090

9191
/**
92-
* @param object $object
92+
* @param array|Traversable|Paginator $object
9393
* @param Metadata $metadata
9494
* @return Collection
9595
*/

0 commit comments

Comments
 (0)