Skip to content

Call SetFinality when processing a milestone #2226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sduchesneau wants to merge 3 commits into
base: develop
Choose a base branch
from
+7 −0
Open

Call SetFinality when processing a milestone #2226

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61dec30
call SetFinalized when successfully processing a milestone
sduchesneau May 14, 2026
05c624e
eth: also publish milestone block as safe and re-check canonical at
sduchesneau May 21, 2026
bc0fd91
remove SetSafe as was suggested by @kamuikatsurgi
sduchesneau May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions eth/handler_bor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,14 @@ func (h *ethHandler) handleMilestone(ctx context.Context, eth *Ethereum, milesto

h.downloader.ProcessMilestone(num, hash)

// Publish the milestone block as finalized and safe. Re-resolve via the
// canonical number→hash mapping so a reorg between verification and this
// write can't promote a stale or non-canonical header.
if block := eth.blockchain.GetBlockByNumber(num); block != nil && block.Hash() == hash {
eth.blockchain.SetFinalized(block.Header())
eth.blockchain.SetSafe(block.Header())
Comment thread
kamuikatsurgi marked this conversation as resolved.
Outdated
}

return nil
}

Expand Down