Skip to content

[Common/Core] disentangle fwdtrackUtilities.h from ASoA.h#16878

Merged
dsekihat merged 1 commit into
AliceO2Group:masterfrom
aalkin:common-core-no-asoa
Jul 1, 2026
Merged

[Common/Core] disentangle fwdtrackUtilities.h from ASoA.h#16878
dsekihat merged 1 commit into
AliceO2Group:masterfrom
aalkin:common-core-no-asoa

Conversation

@aalkin

@aalkin aalkin commented Jun 30, 2026

Copy link
Copy Markdown
Member

See description of #16823

@github-actions github-actions Bot changed the title Common/Core: disentangle fwdtrackUtilities.h from ASoA.h [Common/Core] disentangle fwdtrackUtilities.h from ASoA.h Jun 30, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 2 errors, ⚠️ 3 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for d38ea06 at 2026-06-30 18:29:

No log files found

Full log here.

@dsekihat dsekihat merged commit b6c8dab into AliceO2Group:master Jul 1, 2026
14 of 17 checks passed
@alibuild

alibuild commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d38ea06 at 2026-07-01 21:00:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ grep -E '^/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/.+: error: ' /sw/BUILD/df43be56f938559374ab14d822274c89f8d62922/O2Physics-code-check/error-log.txt
++ sed -e s,/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/,,g
++ sort -V
++ uniq
++ grep -E '^/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/.+: warning: ' /sw/BUILD/df43be56f938559374ab14d822274c89f8d62922/O2Physics-code-check/error-log.txt
++ sed -e s,/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/,,g
++ sort -V
++ uniq
++ true
+++ wc -l
++ N_ERROR=2
+++ wc -l
++ N_WARNING=0
++ echo 'Found 2 errors and 0 warnings.'
Found 2 errors and 0 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/df43be56f938559374ab14d822274c89f8d62922/O2Physics-code-check/errors.txt
Common/Core/fwdtrackUtilities.h:21:10: error: 'Framework/DataTypes.h' file not found [clang-diagnostic-error]
Common/Core/fwdtrackUtilities.h:35:11: error: variable 'o2' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants