Skip to content

Fix Nix + Playwright [SYNTH-209]#1444

Open
0xda157 wants to merge 9 commits into
devfrom
dionkud/209/nix-playwright
Open

Fix Nix + Playwright [SYNTH-209]#1444
0xda157 wants to merge 9 commits into
devfrom
dionkud/209/nix-playwright

Conversation

@0xda157

@0xda157 0xda157 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Task

SYNTH-209

Symptom

nix users are unable to get playwright via the nix shell

Solution

add playwright back and update the flake inputs. likely the issue was the locked version of nixpkgs had an old playwright version

Verification

things work locally now! I also added a github actions workflow to prevent this from happening in the future.


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

0xda157 added 2 commits July 23, 2026 13:51
Flake lock file updates:

• Updated input 'nixpkgs':
    'github:nixos/nixpkgs/d407951447dcd00442e97087bf374aad70c04cea?narHash=sha256-8i/87eeoqiGE4yOTjwSA3Eh/ziJRQEmd/unYU%2BK27sk%3D' (2026-07-05)
  → 'github:nixos/nixpkgs/241313f4e8e508cb9b13278c2b0fa25b9ca27163?narHash=sha256-vlHUuqAcbcH2RKmHbPiuQzbv1pnzzavXnI62RD0bqCU%3D' (2026-07-19)
@0xda157
0xda157 requested a review from azaleacolburn July 23, 2026 21:03
@0xda157
0xda157 requested review from a team as code owners July 23, 2026 21:03
@0xda157
0xda157 requested a review from PepperLola July 23, 2026 21:03
@0xda157
0xda157 force-pushed the dionkud/209/nix-playwright branch 4 times, most recently from 3b2e7cb to 724fef1 Compare July 23, 2026 21:43
Comment thread .github/workflows/NixTest.yml Outdated
@0xda157
0xda157 force-pushed the dionkud/209/nix-playwright branch 2 times, most recently from 232eca9 to 06d65fd Compare July 23, 2026 22:11
@0xda157
0xda157 force-pushed the dionkud/209/nix-playwright branch from 06d65fd to 8978444 Compare July 23, 2026 22:12
@0xda157
0xda157 requested a review from rutmanz July 23, 2026 22:16

@azaleacolburn azaleacolburn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests run for me

@AlexD717 AlexD717 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rutmanz rutmanz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just trying to minimize the compute time these tests take, I'm not sure if Autodesk has to pay for it or not but if we're able to do this more efficiently without sacrificing the test quality that would be nice

Comment thread .github/workflows/NixTest.yml Outdated
@0xda157
0xda157 requested a review from rutmanz July 24, 2026 16:32
@0xda157
0xda157 force-pushed the dionkud/209/nix-playwright branch from 3aee68b to 2483059 Compare July 24, 2026 20:59
@PepperLola PepperLola added the development Related to the development process (workflows, dev-facing improvements, etc.) label Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development Related to the development process (workflows, dev-facing improvements, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants