Mirabuf Scene Object OBB memory fixes [SYNTH-278]#1446
Open
BrandonPacewic wants to merge 7 commits into
Open
Conversation
azaleacolburn
requested changes
Jul 24, 2026
azaleacolburn
left a comment
Contributor
There was a problem hiding this comment.
I have several thoughts, but most of all I'm just confused about the motivation behind some of these changes.
- I agree with the memory management changes, thank you for those.
- I don't like your usage of three objects. I seems to me like you're doing all your math with three objects and then just converting to jolt at the end. Using three objects makes it seem like they are intended for use in the scene rendering system. You're making the code less readable for the sake of not having to clone a jolt quaternion? If anything, jolt quaternion application should be faster enough to make up the difference. Plus, you're optimizing in places that almost certainly aren't bottlenecks.
- I have some other more specific thoughts that I left as comments.
[SYNTH-278][SYNTH-278]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
SYNTH-278
Symptom
Problems related to how we deal with jolt memory within our object bounding box logic.
Solution
Used a Asan build to directly confirm where the memory issues were and fixed them.
Verification
Before merging, ensure the following criteria are met: