Skip to content

Mirabuf Scene Object OBB memory fixes [SYNTH-278]#1446

Open
BrandonPacewic wants to merge 7 commits into
devfrom
branp/278/obb-simplification
Open

Mirabuf Scene Object OBB memory fixes [SYNTH-278]#1446
BrandonPacewic wants to merge 7 commits into
devfrom
branp/278/obb-simplification

Conversation

@BrandonPacewic

Copy link
Copy Markdown
Member

Task

SYNTH-278

Symptom

Problems related to how we deal with jolt memory within our object bounding box logic.

Solution

Used a Asan build to directly confirm where the memory issues were and fixed them.

Verification

  • Spawn a robot with the COM indicator enabled, confirm it works.
  • Spawn a robot in a field with protected/scoring zones, confirm zone-overlap detection still works and OBB tracks robot position/rotation correctly.

Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@BrandonPacewic BrandonPacewic self-assigned this Jul 24, 2026
@BrandonPacewic
BrandonPacewic requested review from a team as code owners July 24, 2026 16:59
@BrandonPacewic BrandonPacewic added mirabuf Relating to the mirabuf format refactor The most important part of software development. labels Jul 24, 2026

@azaleacolburn azaleacolburn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have several thoughts, but most of all I'm just confused about the motivation behind some of these changes.

  1. I agree with the memory management changes, thank you for those.
  2. I don't like your usage of three objects. I seems to me like you're doing all your math with three objects and then just converting to jolt at the end. Using three objects makes it seem like they are intended for use in the scene rendering system. You're making the code less readable for the sake of not having to clone a jolt quaternion? If anything, jolt quaternion application should be faster enough to make up the difference. Plus, you're optimizing in places that almost certainly aren't bottlenecks.
  3. I have some other more specific thoughts that I left as comments.

Comment thread fission/src/mirabuf/MirabufSceneObject.ts Outdated
Comment thread fission/src/mirabuf/MirabufSceneObject.ts Outdated
Comment thread fission/src/mirabuf/MirabufSceneObject.ts Outdated
Comment thread fission/src/mirabuf/MirabufSceneObject.ts Outdated
Comment thread fission/src/mirabuf/MirabufSceneObject.ts
Comment thread fission/src/mirabuf/MirabufSceneObject.ts Outdated
Comment thread fission/src/mirabuf/MirabufSceneObject.ts Outdated
Comment thread fission/src/mirabuf/MirabufSceneObject.ts Outdated
Comment thread fission/src/mirabuf/MirabufSceneObject.ts Outdated
@BrandonPacewic BrandonPacewic changed the title Mirabuf Scene Object OBB Simplification [SYNTH-278] Mirabuf Scene Object OBB memory fixes [SYNTH-278] Jul 24, 2026
@BrandonPacewic BrandonPacewic added bug Fixes an issue and removed refactor The most important part of software development. labels Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes an issue mirabuf Relating to the mirabuf format

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants