Add support for new end-of-RIB elem#60
Open
alistairking wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates pybgpstream to recognize and expose the new libbgpstream BGPSTREAM_ELEM_TYPE_END_OF_RIB element type (paired with CAIDA/libbgpstream#258), and documents the corresponding elemtype filter value.
Changes:
- Add
BGPSTREAM_ELEM_TYPE_END_OF_RIBhandling inBGPElem_get_fields, exposing the elementprefix. - Update API docs to include
endofribas a validelemtypefilter value.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/_pybgpstream_bgpelem.c | Adds type-specific field support for the new END_OF_RIB element type. |
| docs/api__pybgpstream.rst | Documents endofrib as an elemtype filter option. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with CAIDA/libbgpstream#258