fix: allow OpenSubsonic extension check on low security servers - #268
Open
mytja wants to merge 3 commits into
Open
fix: allow OpenSubsonic extension check on low security servers#268mytja wants to merge 3 commits into
mytja wants to merge 3 commits into
Conversation
Some servers, such as Nextcloud/Owncloud Music don't support token-based authentication. This made lyrics unavailable to clients connecting to such servers. This commit fixes this behaviour, allowing clients with passwords to ping server to query if it's OpenSubsonic and query all available extensions.
mytja
marked this pull request as draft
July 16, 2024 22:05
Author
|
I think I have another problem, but I don't think it's related to my commit. However, I might be totally wrong. After switching to a song with no lyrics available on the server (in my case "The Night We Met") from a song (in my case "Offline") which has lyrics available both from Attaching the screen recording to better describe the situation screen.mp4 |
mytja
marked this pull request as ready for review
July 16, 2024 22:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some servers, such as Nextcloud/Owncloud Music don't support token-based authentication. This made lyrics unavailable to clients connecting to such servers. This commit fixes this behaviour, allowing clients with passwords to ping server to query if it's OpenSubsonic and query all available extensions.
Before:
No time-synchronized lyrics
Now: