Skip to content

Avoid X=0 PumpAll AI choices #11124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rauglothgor wants to merge 1 commit into
base: master
Choose a base branch
from
+22 −2
Open

Avoid X=0 PumpAll AI choices #11124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions forge-ai/src/main/java/forge/ai/ability/PumpAllAi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,14 @@ protected AiAbilityDecision checkApiLogic(final Player ai, final SpellAbility sa
}
}

final int power = AbilityUtils.calculateAmount(source, sa.getParam("NumAtt"), sa);
final int defense = AbilityUtils.calculateAmount(source, sa.getParam("NumDef"), sa);
final String numAttack = sa.getParamOrDefault("NumAtt", "0");
final String numDefense = sa.getParamOrDefault("NumDef", "0");
if (usesPaidX(sa, numAttack, numDefense) && !setPaidX(sa, ai)) {
return new AiAbilityDecision(0, AiPlayDecision.CantPlayAi);
}

final int power = AbilityUtils.calculateAmount(source, numAttack, sa);
final int defense = AbilityUtils.calculateAmount(source, numDefense, sa);
final List<String> keywords = sa.hasParam("KW") ? Arrays.asList(sa.getParam("KW").split(" & ")) : new ArrayList<>();
final PhaseType phase = game.getPhaseHandler().getPhase();

Expand Down Expand Up @@ -162,4 +168,18 @@ boolean pumpAgainstRemoval(Player ai, SpellAbility sa, List<Card> comp) {
}
return false;
}

private boolean usesPaidX(final SpellAbility sa, final String numAttack, final String numDefense) {
return sa.getSVar("X").equals("Count$xPaid") && (numAttack.contains("X") || numDefense.contains("X"));
}

private boolean setPaidX(final SpellAbility sa, final Player ai) {
final SpellAbility root = sa.getRootAbility();
final Cost rootCost = root.getPayCosts();
if (rootCost == null || !rootCost.hasXInAnyCostPart()) {
return true;
}
root.setXManaCostPaid(null);
return ComputerUtilCost.setMaxXValue(root, ai, sa.isTrigger()) > 0;
}
}