Autotap - Add support for filter abilities#11173
Conversation
tool4ever
left a comment
There was a problem hiding this comment.
Hopefully this'll work better than the last AI attempt 🤔
Anyway this is huge and the highlighting part is already a separate feature: #5112
Please extract that into its own PR first, it'll certainly be useful for testing the rest of this 👍
|
|
||
| addCard("Mountain", p); | ||
| addCard("Plains", p); | ||
| addCard("Boros Signet", p); |
There was a problem hiding this comment.
after we're done with most code concerns need to remove AI:RemoveDeck:All from all applicable cards so I can batch fuzz random generated decks for crashes
| final int depth = manaPaymentDepth.get() + 1; | ||
| manaPaymentDepth.set(depth); | ||
| final boolean outermost = depth == 1; | ||
| try { |
There was a problem hiding this comment.
this will need a cleaner solution than this massive wrap for which you're trying to ignore the code style
at the same time a ThreadLocal seems overkill and only risks wrong usage of such non obviously "constrained in concurrency" class
why not simply some overload for a nested entrypoint instead?
Changes to auto-tap detection:
You can add the VM option
-Dforge.debugManaPayment=trueto help visualize what it attempts to use.Let me know if there are edge cases it misses.