Remove WASM quickcheck infrastructure - #479
Merged
allanbrondum merged 4 commits intoAug 20, 2026
Merged
Conversation
allanbrondum
commented
Aug 12, 2026
Comment on lines
+907
to
+931
| /// Reports back an error to the host when compiled to wasm | ||
| /// Used internally, not meant to be called directly by contract writers | ||
| #[doc(hidden)] | ||
| #[cfg(all(feature = "wasm-test", target_arch = "wasm32"))] | ||
| pub fn report_error(message: &str, filename: &str, line: u32, column: u32) { | ||
| let msg_bytes = message.as_bytes(); | ||
| let filename_bytes = filename.as_bytes(); | ||
| unsafe { | ||
| crate::prims::report_error( | ||
| msg_bytes.as_ptr(), | ||
| msg_bytes.len() as u32, | ||
| filename_bytes.as_ptr(), | ||
| filename_bytes.len() as u32, | ||
| line, | ||
| column, | ||
| ) | ||
| }; | ||
| } | ||
|
|
||
| /// Reports back an error to the host when compiled to wasm | ||
| /// Used internally, not meant to be called directly by contract writers | ||
| #[doc(hidden)] | ||
| #[cfg(not(all(feature = "wasm-test", target_arch = "wasm32")))] | ||
| pub fn report_error(_message: &str, _filename: &str, _line: u32, _column: u32) {} | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Moved here from test_infrastructure
limemloh
approved these changes
Aug 13, 2026
| /// See the [crate](../concordium_std/#deprecating-the-test_infrastructure) | ||
| /// documentation for more details. | ||
| /// Consider using the concrete type [`ExternParameter`](crate::types::ExternParameter) instead. | ||
| pub trait HasParameter: Read + Seek + HasSize {} |
Collaborator
There was a problem hiding this comment.
Are these traits still useful? maybe these should be marked deprecated as well.
Contributor
Author
There was a problem hiding this comment.
I think we can remove them at some point, since they all (or almost all?) only have one implementation.
Base automatically changed from
ar/cor-2473-implement-a-default-allocator-for-concordium-std-on-wasm32
to
feature/wasm32v1
August 20, 2026 09:46
allanbrondum
deleted the
ar/cor-2474-property-based-tests-on-wasm32-target
branch
August 20, 2026 09:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Remove the quickcheck infrastructure. Keep the
TestHostget_randomaccess from WASM tests.Changes
TestEnv::get_randomtest_infrastructuremodule. Moved out the stuff that is not deprecated (report_error)Checklist
hard-to-understand areas.