[SPO-53] Support specifying profiles - #209
Merged
Merged
Conversation
rasmus-kirk
marked this pull request as ready for review
November 24, 2025 15:10
rasmus-kirk
force-pushed
the
support-profiles
branch
from
November 24, 2025 17:40
f2d226c to
6fb4082
Compare
rasmus-kirk
commented
Nov 26, 2025
rasmus-kirk
force-pushed
the
support-profiles
branch
2 times, most recently
from
November 27, 2025 13:43
cb7a412 to
b4127b5
Compare
rasmus-kirk
commented
Nov 27, 2025
Contributor
Author
|
Also reverted the changes to |
rasmus-kirk
force-pushed
the
support-profiles
branch
from
November 27, 2025 13:50
b4127b5 to
b45a7d9
Compare
limemloh
approved these changes
Nov 28, 2025
Co-authored-by: Emil Holm Gjørup <eg@concordium.com>
…mart-contract-tools into support-profiles
Contributor
Author
|
I'm merging this if it's good to you @allanbrondum |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
I split up #208 to make the review easier. This only handles specifying profiles with the
--profileparameter, reproducible builds in workspaces will not work. This PR also doesn't support passing in the--profileflag to reproducible builds. Given that the coming PR will be about reproducible builds, I chose to leave this PR lighter.Changes
cargo buildto use a single wrapper method to more easily manage the arguments we pass.--releaseflag to specify the release profile.build_contractnow takes theBuildOptionsstruct for simplicity. This was more ergonomic than adding yet another parameter for the release profile.Testing
I tested this feature by adding:
To the reproducible smart contract and running:
And:
And for good measure:
Checklist
hard-to-understand areas.