Implement Grid3D.find_index() and enable da.sel() for dfs3 data#919
Open
ecomodeller wants to merge 1 commit into
Open
Implement Grid3D.find_index() and enable da.sel() for dfs3 data#919ecomodeller wants to merge 1 commit into
ecomodeller wants to merge 1 commit into
Conversation
Grid3D.find_index() was raising NotImplementedError, making da.sel(x=..., y=..., z=...) unusable for dfs3 data. This implements the full find_index method mirroring Grid2D's approach, along with bbox, contains, _xy_to_index, and _bbox_to_index helpers. DataArray.sel() is updated to handle the 3-tuple (ii, jj, kk) return values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Grid3D.find_index()supporting x, y, z, coords, and area argumentsDataArray.sel()to handle 3-tuple indices from Grid3Dbbox,contains,_xy_to_index,_bbox_to_indexhelpers to Grid3D