Skip to content

Drop Python 3.11 support #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecomodeller merged 4 commits into from
Jun 29, 2026
Merged

Drop Python 3.11 support #674

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0307fa
Fix mypy union-attr error in vertical comparison colorbar
ecomodeller Jun 24, 2026
acf9008
Fix overload-overlap mypy error in ComparerCollection.__getitem__
ecomodeller Jun 25, 2026
d411fce
Drop Python 3.11 support to fix typecheck CI
ecomodeller Jun 25, 2026
761d71a
Add Python 3.14 trove classifier
ecomodeller Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/modelskill/comparison/_collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ def rename(self, mapping: Dict[str, str]) -> "ComparerCollection":
return ComparerCollection(cmps)

@overload
def __getitem__(self, x: slice | Iterable[Hashable]) -> ComparerCollection: ...
def __getitem__(self, x: slice | Iterable[Hashable]) -> ComparerCollection: ... # type: ignore[overload-overlap]

@overload
def __getitem__(self, x: int | Hashable) -> Comparer: ...
Expand Down
4 changes: 3 additions & 1 deletion src/modelskill/comparison/_vertical_comparison.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,9 @@ def hovmoller(
V = v.reshape(len(T), n_layers)
T_grid, _ = np.meshgrid(T, np.arange(n_layers), indexing="ij")
cf = ax.contourf(T_grid, Z, V, **kwargs)
cbar = ax.figure.colorbar(cf, ax=ax)
fig = ax.figure
assert fig is not None
cbar = fig.colorbar(cf, ax=ax)
cbar.set_label(cmp._unit_text)
if self._pos_z():
ax.invert_yaxis()
Expand Down
Loading