feat(hyades): separate Job and Pod metadata for initializer - #367
Open
rseleven wants to merge 1 commit into
Open
feat(hyades): separate Job and Pod metadata for initializer#367rseleven wants to merge 1 commit into
rseleven wants to merge 1 commit into
Conversation
Contributor
Author
|
@nscuro, please take a look |
nscuro
reviewed
Jun 26, 2026
nscuro
left a comment
nscuro
left a comment
Member
There was a problem hiding this comment.
Does it not create a confusing asymmetry when the labels / podLabels and annotations / podAnnotations distinctions only exist for the initializer, but not for the api-server and frontend deployments?
BREAKING CHANGE: apiServer.annotations and frontend.annotations were previously pod-level annotations. They are now resource-level annotations on the Deployment. Use podAnnotations for pod-level annotations. Signed-off-by: rseleven <73898556+rseleven@users.noreply.github.com>
rseleven
force-pushed
the
hyades/initializer
branch
from
June 26, 2026 18:05
72eee64 to
49c73fb
Compare
Contributor
Author
|
@nscuro, ready |
Contributor
Author
|
@nscuro, ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split annotations and labels into Job-level and Pod-template-level to allow independent customization. Add support for custom labels on both Job and Pod. Wrap labels blocks in conditional to prevent rendering empty labels fields.