fix(ui): resolve unclickable watch path removal button #4782
Open
imrja8 wants to merge 3 commits into
Open
Conversation
|
Nice fix, and the root-cause writeup on
One more thing: the description mentions an "Enable Submodules" toggle alignment tweak, but I do not see it in the diff (only the badge fix landed). Might be worth checking whether that change got committed. Thanks for jumping on this one. |
Contributor
Author
|
@fredhii Sure. I'll add the accessibility suggestions, review the additional accessibility changes in your PR, adopt any relevant improvements, and add you as a co-author on the commit if I use your changes. |
…ton a11y - Properly negate FormItem spacing for the 'Enable Submodules' toggle inline layout - Drop redundant focus outline hide and add aria-label for watchpath delete buttons Co-authored-by: Fredy Acuña <fredhiixd@gmail.com>
Co-Authored-By: Fredy Acuna <57413945+fredhii@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This PR fixes an issue where the "X" button used to remove watch paths was completely unclickable across all Git provider forms (both Application and Compose).
It also includes a minor UI tweak to perfectly vertically align the
Enable Submodulestoggle switch and label.Why the issue existed:
The native Shadcn
Badgecomponent comes with a default CSS rule ([&>svg]:pointer-events-none). Because the<X>icon was rendered as a direct SVG child of the badge, the browser was applying this rule, which mathematically swallowed all click events and made the "X" strictly non-interactive.How it was solved:
Instead of fighting CSS specificity with
!importantutility class overrides, this PR takes a native structural approach. The<X>icon is now wrapped in a standard<button>element. This naturally prevents the parent badge's SVG CSS rule from targeting the icon, fully restoring interactivity in a clean, HTML-native way.Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #4780
Screenshots & Recordings
Screen.Recording.2026-07-09.at.16.23.50.mov