[codex] Brand macOS app as Euro-Office - #16
Draft
flobrown wants to merge 5 commits into
Draft
Conversation
joey-in-the-middle
left a comment
joey-in-the-middle
left a comment
There was a problem hiding this comment.
this review submits some some concerns about the approach adopted to this change. In addition, I feel a PR with 337 changes should be splitted in multiple changes. Still unsure the project has such of guidelines, but I believe it should be defined if we want an open collaboration on the project.
There was a problem hiding this comment.
is this an official image asset? if none exists, please prioritize a brand identity activity
| welDescr: 'Your sovereign office for local documents and connected clouds.', | ||
| welNeedHelp: 'Need help? Visit our $1.', | ||
| textHelpCenter: 'Help Center', | ||
| textHelpCenter: 'project page', |
| bgColorWinXP: '#287ca9', | ||
| }, | ||
| icon: '#docx-big', | ||
| const documentTypes = [ |
There was a problem hiding this comment.
is this change related to the rebranding? I feel the PR should not spread across different topics. Please raise unrelated changes as separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Euro-Office.app, bundle idorg.euro-office.desktopeditors, URL schemeeuro-office.instead of hardcoded
ONLYOFFICE.update feed exists.
Validation
git diff --checkplutil -lintfor the three macOS app Info.plists and the Xcode projectplutil -lintfor localizedInfoPlist.stringsxcodebuild -project macos/ONLYOFFICE.xcodeproj -listxcodebuild -project macos/ONLYOFFICE.xcodeproj -scheme ONLYOFFICE-arm -configuration Release -showBuildSettingsObserved build settings:
EXECUTABLE_NAME = Euro-OfficeFULL_PRODUCT_NAME = Euro-Office.appPRODUCT_BUNDLE_IDENTIFIER = org.euro-office.desktopeditorsNotes
Full native build orchestration is proposed separately in
DesktopEditors.Developer ID signing and notarization remain optional release gates and are
driven by environment variables.