add media partners#1665
Open
dariagrudzien wants to merge 2 commits into
Open
Conversation
Member
Preview available
|
Closed
dariagrudzien
commented
Jun 23, 2026
|
|
||
| --- | ||
|
|
||
| {logo && ( |
Contributor
Author
There was a problem hiding this comment.
I have second thoughts about this part. I added it to be able to display partners before adding a logo, but I guess we want the build to fail explicitly when we forgot to add a photo before pushing to prod?
Contributor
There was a problem hiding this comment.
yes, I think failing the build if something is missing is better than gracefully handling it 😅
but that's just my general preference.
It's better to explicitly add some generic placeholder in the data than handle that in code, and then make the code require a logo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying one more time, I've had problems resolving conflicts after new design deploy.
Media Partnersinto the Community tab, copyingCommunity Partnerssetup.Replaces #1641