Add ability to request additional scopes from Idp - #1
Conversation
|
Hi, |
|
We just got SSO integrated into Mantis via Authentik with the help of this PR. |
| 'redirect_uri' => '', # is set once the config page is saved | ||
| 'oidc_scopes' => array('openid'), | ||
| 'oidc_uid_claim' => 'name', | ||
| 'oidc_find_usery_by' => 'name', |
There was a problem hiding this comment.
looks like a typo here
| 'oidc_find_usery_by' => 'name', | |
| 'oidc_find_user_by' => 'name', |
There was a problem hiding this comment.
Thank you for finding this typo. FIXED
|
codewise this PR looks good. please fix the small typo and then I will try to test the addition soon! |
cbf8e52 to
dba0e92
Compare
|
Thank you for the review. I fixed the typo and rebased the feature branch to the current head of "master". (Would it have been better to instead not rebase and just apply the suggestion?) |
Add ability to choose whether to match users by name or by email
dba0e92 to
2476e0d
Compare
4 participants
First of all thank you for you work on this plugin. An OIDC for Mantis was definitely needed.
I tried to get this working with authentik but that does not transmit any username when only the
openidscope is requested.So I added an configuration option for requesting additional scopes (like
profileoremail).Also I would like to match users by email rather than username, so I made that configurable as well.
I set the default values so that the current behavior should be left unchanged.