Fix Windows and SSL Wrappers#7
Open
f-michaut wants to merge 1 commit into
Open
Conversation
f-michaut
commented
Jul 2, 2026
f-michaut
commented
Contributor
- Fixed SocketInit not always being odr-used when Sockets are used
- Fixed SocketInit throwing errors which would call terminate()
- Fixed SSL Wrappers copy constructor to really use up_ref
- Fixed SSL Wrappers constness handling
f-michaut
force-pushed
the
fix-windows-and-ssl-wrappers
branch
10 times, most recently
from
cf60702 to
3e4853e
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
3 similar comments
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
f-michaut
force-pushed
the
fix-windows-and-ssl-wrappers
branch
from
3e4853e to
cbd9705
Compare
- Fixed SocketInit not always being odr-used when Sockets are used - Fixed SocketInit throwing errors which would call terminate() - Fixed SSL Wrappers copy constructor to really use up_ref - Fixed SSL Wrappers constness handling
f-michaut
force-pushed
the
fix-windows-and-ssl-wrappers
branch
from
cbd9705 to
61768f7
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
8 similar comments
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.