Update <PieSliceAngularInset /> to use color, strokeWidth and style params instead of paint#666
Open
s77rt wants to merge 4 commits into
Conversation
🦋 Changeset detectedLatest commit: a0c5ecc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@s77rt is attempting to deploy a commit to the formidable-labs Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In web, when rendering slices siblings and a paint e.g
Then the paint in
<Path />seems to affect the descendants siblings (Slice2, etc.) and they do not render correctly. I tried to<Group />each slice with it's own paint but it didn't work either. The paint styles are somehow leaking. I don't think this is necessary a bug in this library. But it's something that can be avoided, since the paint constructed inuseSliceAngularInsetPathonly sets thecolor,strokeWidthandstyle, we can pass those as explicit params to<Path />.Fixes # #652
Type of Change
How Has This Been Tested?
Tested the pie charts in the included example
Before

After
