Skip to content

Update <PieSliceAngularInset /> to use color, strokeWidth and style params instead of paint#666

Open
s77rt wants to merge 4 commits into
FormidableLabs:mainfrom
s77rt:PieSliceAngularInset-use-color-parms-instead-of-paint
Open

Update <PieSliceAngularInset /> to use color, strokeWidth and style params instead of paint#666
s77rt wants to merge 4 commits into
FormidableLabs:mainfrom
s77rt:PieSliceAngularInset-use-color-parms-instead-of-paint

Conversation

@s77rt

@s77rt s77rt commented Jun 1, 2026

Copy link
Copy Markdown

Description

In web, when rendering slices siblings and a paint e.g

<Slice1 />
<Path paint={paint} />
<Slice2 />

Then the paint in <Path /> seems to affect the descendants siblings (Slice2, etc.) and they do not render correctly. I tried to <Group /> each slice with it's own paint but it didn't work either. The paint styles are somehow leaking. I don't think this is necessary a bug in this library. But it's something that can be avoided, since the paint constructed in useSliceAngularInsetPath only sets the color, strokeWidth and style, we can pass those as explicit params to <Path />.

Fixes # #652

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Tested the pie charts in the included example

Before
Screenshot 2026-06-01 at 4 30 15 PM

After
Screenshot 2026-06-01 at 4 36 17 PM

@changeset-bot

changeset-bot Bot commented Jun 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a0c5ecc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
victory-native Major
example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jun 1, 2026

Copy link
Copy Markdown

@s77rt is attempting to deploy a commit to the formidable-labs Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant