Skip to content

biglake_iceberg_table: Add sleep to test #18229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rambleraptor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

biglake_iceberg_table: Add sleep to test #18229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion mmv1/third_party/terraform/services/biglakeiceberg/resource_biglake_iceberg_table_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,10 @@ func TestAccBiglakeIcebergIcebergTable_vendedCredentials(t *testing.T) {
acctest.VcrTest(t, resource.TestCase{
PreCheck: func() { acctest.AccTestPreCheck(t) },
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
CheckDestroy: testAccCheckBiglakeIcebergIcebergTableDestroyProducer(t),
ExternalProviders: map[string]resource.ExternalProvider{
"time": {},
},
CheckDestroy: testAccCheckBiglakeIcebergIcebergTableDestroyProducer(t),
Steps: []resource.TestStep{
{
Config: testAccBiglakeIcebergIcebergTable_vendedCredentials(context),
Expand Down Expand Up @@ -95,12 +98,22 @@ resource "google_biglake_iceberg_catalog" "catalog" {
credential_mode = "CREDENTIAL_MODE_VENDED_CREDENTIALS"
}

# The catalog's generated service account is not immediately usable in an IAM
# binding right after the catalog is created, so wait for it to propagate before
# referencing it.
resource "time_sleep" "wait_for_biglake_service_account" {
depends_on = [google_biglake_iceberg_catalog.catalog]
create_duration = "60s"
}

# Credential vending downscopes a generated service account to access the GCS
# bucket, so it must be granted access before any table operation runs.
resource "google_storage_bucket_iam_member" "cv_sa_storage_admin" {
bucket = google_storage_bucket.bucket.name
role = "roles/storage.admin"
member = "serviceAccount:${google_biglake_iceberg_catalog.catalog.biglake_service_account}"

depends_on = [time_sleep.wait_for_biglake_service_account]
}

resource "google_biglake_iceberg_namespace" "namespace" {
Expand Down
Loading