* Grouped Ribbon controls do expose designers, needs a closer look (V… - #4074
Open
PWagner1 wants to merge 2 commits into
Open
Conversation
…110) # Fix: Reuse base designer for ribbon ThemeComboBox (#4059) ## Summary `KryptonRibbonGroupThemeComboBox` no longer ships a near-duplicate of `KryptonRibbonGroupComboBoxDesigner`. It inherits the base ribbon combo box designer for move/delete/helpers, while theme-specific combo properties stay hidden via the existing `Removed Designer` overrides. ## Related issues - Closes #4059 ## Type of change - [x] Bug fix (`Resolved`) - [ ] Feature / enhancement (`Implemented`) - [ ] **Breaking change** (API removal/rename, behavior change requiring migration, assembly/namespace move) - [ ] Documentation only ## Changes - `Krypton.Ribbon`: Pointed `KryptonRibbonGroupThemeComboBox` at `KryptonRibbonGroupComboBoxDesigner` and removed the TODO that tracked this review. - `Krypton.Ribbon`: Deleted the near-duplicate `KryptonRibbonGroupThemeComboBoxDesigner.cs`. ## Affected packages & target frameworks - Packages: `Krypton.Ribbon` - TFMs verified: project Debug build of `Krypton.Ribbon` ## Validation - TestForm demo: `RibbonTest` (already hosts `kryptonRibbonGroupThemeComboBox1`). - Manual steps: 1. Open `RibbonTest` in the Visual Studio designer. 2. Select the ribbon group ThemeComboBox; use Move First/Previous/Next/Last, Delete, Visible, and Design Helpers. 3. Confirm `DefaultPalette` remains available and editable; confirm `Text`, `Items`, `DropDownStyle`, and autocomplete properties stay hidden. 4. Run the form and change themes via the ribbon ThemeComboBox. - Build: `dotnet build ".\Source\Krypton Components\Krypton.Ribbon\Krypton.Ribbon 2022.csproj" -c Debug` ## Changelog - Entry added to `Documents/Changelog/Changelog.md`: ```markdown * Resolved [#4059](#4059), Grouped Ribbon controls do expose designers, needs a closer look * `KryptonRibbonGroupThemeComboBox` now reuses the base ribbon combo box designer instead of a near-duplicate Theme-specific designer ``` ## Breaking changes & migration None. `KryptonRibbonGroupThemeComboBoxDesigner` was `internal` and not part of the public API. Design-time verbs may say "ComboBox" instead of "ThemeComboBox"; behavior is unchanged. ## Checklist - [x] Builds for `net472` and is C# 7.3 compatible where required - [x] New compiler/analyzer warnings in touched code addressed - [x] `Documents/Changelog/Changelog.md` updated - [ ] TestForm demo added or updated (features / observable bug fixes) — existing `RibbonTest` covers this - [ ] `Documents/Development/` guide added (substantial features) - [ ] Screenshots/GIFs included (UI changes) - [x] Breaking-change impact and TFM notes documented above
PWagner1
added
area:ribbon
…-do-expose-designers-needs-a-closer-look
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…110)
Fix: Reuse base designer for ribbon ThemeComboBox (#4059)
Summary
KryptonRibbonGroupThemeComboBoxno longer ships a near-duplicate ofKryptonRibbonGroupComboBoxDesigner. It inherits the base ribbon combo box designer for move/delete/helpers, while theme-specific combo properties stay hidden via the existingRemoved Designeroverrides.Related issues
Type of change
Resolved)Implemented)Changes
Krypton.Ribbon: PointedKryptonRibbonGroupThemeComboBoxatKryptonRibbonGroupComboBoxDesignerand removed the TODO that tracked this review.Krypton.Ribbon: Deleted the near-duplicateKryptonRibbonGroupThemeComboBoxDesigner.cs.Affected packages & target frameworks
Krypton.RibbonKrypton.RibbonValidation
RibbonTest(already hostskryptonRibbonGroupThemeComboBox1).RibbonTestin the Visual Studio designer.DefaultPaletteremains available and editable; confirmText,Items,DropDownStyle, and autocomplete properties stay hidden.dotnet build ".\Source\Krypton Components\Krypton.Ribbon\Krypton.Ribbon 2022.csproj" -c DebugChangelog
Documents/Changelog/Changelog.md:Breaking changes & migration
None.
KryptonRibbonGroupThemeComboBoxDesignerwasinternaland not part of the public API. Design-time verbs may say "ComboBox" instead of "ThemeComboBox"; behavior is unchanged.Checklist
net472and is C# 7.3 compatible where requiredDocuments/Changelog/Changelog.mdupdatedRibbonTestcovers thisDocuments/Development/guide added (substantial features)