Skip to content

Add cargo audit check for Rust apps#269

Open
yogh333 wants to merge 3 commits into
masterfrom
y333/run_cargo_audit
Open

Add cargo audit check for Rust apps#269
yogh333 wants to merge 3 commits into
masterfrom
y333/run_cargo_audit

Conversation

@yogh333

@yogh333 yogh333 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@yogh333
yogh333 requested a review from a team as a code owner July 8, 2026 16:39
@yogh333
yogh333 requested review from iartemov-ledger and removed request for a team July 8, 2026 16:39
@yogh333
yogh333 force-pushed the y333/run_cargo_audit branch from 8c4e659 to 73a4125 Compare July 8, 2026 16:43
@yogh333
yogh333 requested a review from Copilot July 8, 2026 16:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new reusable GitHub Actions check to run cargo audit for Rust-based Ledger apps, and wires it into the existing guidelines enforcer so Rust apps are automatically scanned for vulnerable dependencies.

Changes:

  • Added a new reusable workflow (_check_cargo_audit.yml) that checks out the app repo and runs cargo audit.
  • Integrated the new cargo-audit check into reusable_guidelines_enforcer.yml for Rust apps only.
  • Documented the addition in CHANGELOG.md (v1.105.0).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
CHANGELOG.md Documents the new cargo audit workflow addition.
.github/workflows/reusable_guidelines_enforcer.yml Dispatches the new cargo audit check when is_rust == 'true'.
.github/workflows/_check_cargo_audit.yml New reusable workflow that clones the app repository and runs cargo audit.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/_check_cargo_audit.yml

@iartemov-ledger iartemov-ledger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be an issue with cargo-bins/cargo-binstall.

Comment thread .github/workflows/_check_cargo_audit.yml Outdated
Comment thread .github/workflows/_check_cargo_audit.yml
@yogh333
yogh333 force-pushed the y333/run_cargo_audit branch from d9f43d8 to fc94653 Compare July 9, 2026 14:01
@yogh333
yogh333 requested a review from iartemov-ledger July 9, 2026 14:14
iartemov-ledger
iartemov-ledger previously approved these changes Jul 9, 2026

@iartemov-ledger iartemov-ledger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI it already fails for app-starknet in terms of audit: https://github.com/LedgerHQ/app-starknet/actions/runs/29029564293/job/86158413411?pr=66 ;)

@tdejoigny-ledger

Copy link
Copy Markdown
Contributor

@yogh333 could we run this for all rust app to have an idea of the impact ?

@yogh333

yogh333 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

I am wondering if it shouldn't be put as a separate workflow (reusable_cargo_audit.yml or reusable_security_enforcer.yml) that will be called specifically by Rust apps. Adding it in reusable_guidelines_enforcer.yml is maybe too overkill, and is it really the right place?
WDYT?
@tdejoigny-ledger @iartemov-ledger

@yogh333

yogh333 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

For your information here is the list of impacted Rust apps:

app-starknet => fixed
app-zcash
app-iota-rebased

@iartemov-ledger

Copy link
Copy Markdown
Contributor

I am wondering if it shouldn't be put as a separate workflow (reusable_cargo_audit.yml or reusable_security_enforcer.yml) that will be called specifically by Rust apps. Adding it in reusable_guidelines_enforcer.yml is maybe too overkill, and is it really the right place? WDYT? @tdejoigny-ledger @iartemov-ledger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants