Skip to content

Keep the restart_workers monitor alive on transient errors (and drop debug prints) #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lollinng wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Keep the restart_workers monitor alive on transient errors (and drop debug prints) #694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions src/litserve/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1605,8 +1605,8 @@ def _start_worker_monitoring(
uvicorn_workers: dict[str, Union[mp.Process, threading.Thread]],
):
def monitor():
try:
while not self._shutdown_event.is_set():
while not self._shutdown_event.is_set():
try:
broken_workers = {}

for i, proc in enumerate(self.inference_workers):
Expand Down Expand Up @@ -1655,17 +1655,15 @@ def monitor():
resp.response_queue.append((None, LitAPIStatus.ERROR))

resp.event.set()
print(f"[monoriting] Marked {uid} set")

print(f"[monoriting] Worker {worker_id} is dead. Restarting it")
logger.info(f"Worker {worker_id} is dead. Restarting it")
lit_api = self.litapi_connector.lit_apis[lit_api_id]
self.inference_workers[idx] = self.launch_single_inference_worker(lit_api, worker_id)
print(f"[monoriting] Worker {worker_id} has been started.")

time.sleep(self.monitor_internal)
logger.info(f"Worker {worker_id} has been restarted")
except Exception:
logger.exception("Error in worker monitoring loop")

except Exception as e:
print(e)
time.sleep(self.monitor_internal)

t = threading.Thread(target=monitor, daemon=True, name="litserve-monitoring")
t.start()