build: keep comp manpage adoc rules out of the kbuild pass#4227
Merged
Conversation
In the KERNELRELEASE (kbuild) pass COMPS is rebuilt from a wildcard that mixes hal/components and hal/drivers, so the adoc targets derived from it picked up hal/drivers/*.comp entries that fail the hal/components/%.comp static pattern rule, breaking RTAI builds. Move the manpage adoc vars and rules inside the non-kbuild else branch. Fixes LinuxCNC#4226.
Contributor
Author
Contributor
|
Yes, it is fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the KERNELRELEASE (kbuild) pass
COMPSis rebuilt from a wildcard that mixeshal/componentsandhal/drivers. The manpage adoc targets were derived fromCOMPSoutside the KERNELRELEASE guard, so in that pass they picked uphal/drivers/*.compentries that fail thehal/components/%.compstatic pattern rule, breaking RTAI builds.Move the manpage adoc vars and rules inside the non-kbuild
elsebranch, where manpage generation belongs. uspace builds are unaffected.Fixes #4226.