feat: sibling engine frameworks (0.10.13-1-SNAPSHOT) — device code-signing fix#8
Open
iamstuffed wants to merge 1 commit into
Open
feat: sibling engine frameworks (0.10.13-1-SNAPSHOT) — device code-signing fix#8iamstuffed wants to merge 1 commit into
iamstuffed wants to merge 1 commit into
Conversation
The engine libraries are now their own top-level binaryTargets (inference_engine, inference_engine_llamacpp_backend, ie_zip) listed in every product that needs them, instead of dylibs nested inside LeapSDK.framework/Frameworks. SPM embeds + code-signs each with the consumer identity on device, fixing the on-device 'code signature invalid' rejection that Xcode's Embed & Sign never resolves for nested dylibs. See leap-android-sdk#281.
There was a problem hiding this comment.
Pull request overview
Updates the Swift Package Manager manifest to distribute the inference-engine runtime as separate sibling binary frameworks, ensuring SPM embeds and code-signs them with the consuming app’s identity (fixing on-device “code signature invalid” failures caused by nested dylibs inside LeapSDK.framework/Frameworks).
Changes:
- Introduces a shared
releaseBasefor binary target URLs and updates the release tag tov0.10.13-1-SNAPSHOT. - Adds three new binary targets (
inference_engine,inference_engine_llamacpp_backend,ie_zip) and includes them in theLeapSDK,LeapModelDownloader, andLeapUIproducts. - Updates checksums for the
LeapSDKandLeapModelDownloaderzips to match the new release artifacts while keeping unchanged targets’ checksums intact.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ship the inference-engine libraries as their own top-level frameworks (their own binaryTargets:
inference_engine,inference_engine_llamacpp_backend,ie_zip) listed in every product that needs them, instead of dylibs nested insideLeapSDK.framework/Frameworks. SPM embeds + code-signs each with the consumer's identity on device, fixing the on-deviceLibrary not loaded: @rpath/libinference_engine.dylib ... code signature invalidrejection (Xcode "Embed & Sign" never re-signs nested dylibs; the simulator masked it). Same inference engine as 0.10.13-SNAPSHOT.Package.swifttov0.10.13-1-SNAPSHOT, add the three enginebinaryTargets, and list them in theLeapSDK,LeapModelDownloader, andLeapUIproducts.v0.10.13-1-SNAPSHOTcarries all seven xcframework zips. Consumerswift package resolveverified (all checksums match).Companion to the CI/Gradle restructure in Liquid4All/leap-android-sdk#281, which makes future builds emit this layout natively.