Update incorrect range translations#4589
Open
xkello wants to merge 1 commit into
Open
Conversation
Coverage Report for CI Build 29011321355Coverage increased (+0.1%) to 59.115%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions3 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
📦 Build Artifacts Ready
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a misleading validation message shown when a user enters a number outside the allowed range.
Ticket: #4499
Previously, the message told users to select a number strictly lower/higher than the range boundary, when it should say lower/higher or equal to the boundary - since the boundary value itself is valid.
Current behavior
For an allowed range of 1–100:
Entering 101 shows: "Value must be lower than 100" - but 100 is a valid value, so the message is misleading.
Entering 0 shows: "Value must be higher than 1" - same issue in the other direction.
What changed
Updated the validation message strings to say "less than or equal to X" / "greater than or equal to X"
Changes were made to
fieldvalidator.cppmanually and toinput_en.tsusing script.Expected behavior