Fix geocoder endpoint used by location search#905
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change\nSwitch NominatimGeocoder to the current OpenStreetMap Nominatim endpoint and build request URLs with encodeURIComponent. I also made the API key optional so custom services can still pass one when needed.\n\nAdded unit coverage for URL generation and callback behavior in test/util/NominatimGeocoder.test.js.\n\n### Why Should This Be In Core?\nThe current default endpoint points to open.mapquestapi.com, which no longer resolves. That makes text searches in the GoToLocation example look broken because the geocoder request never succeeds.\n\n### Benefits\n- Restores working location search for place names\n- Properly encodes full user queries\n- Keeps optional key support for alternate geocoder services\n- Adds regression tests around the request URL and callback handling\n\n### Potential Drawbacks\nThe default geocoder backend changes from MapQuest-hosted Nominatim to OpenStreetMap Nominatim.\n\n### Applicable Issues\nFixes #897