Build modules under extern in the build tree, not under the source tree#902
Draft
PhilMiller wants to merge 3 commits into
Draft
Build modules under extern in the build tree, not under the source tree#902PhilMiller wants to merge 3 commits into
PhilMiller wants to merge 3 commits into
Conversation
…o ensure configuration correspondence
…configuration correspondence
hellkite500
previously approved these changes
May 30, 2025
hellkite500
dismissed
their stale review
May 30, 2025 23:44
Need to look more closely at failing tests not finding libs in new paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For everything under
extern/, both Git submodules and support libraries, move their build output below the main CMake binary directory, rather than generating acmake_builddirectory under each of them. This avoids issues with the compilation being mis-matched in various ways from the main framework build.This comes at the small cost of duplicative compilation, but I think it's worthwhile, given the frustrating and confusing failure modes that arise from the noted mismatches.
Changes
CMakeLists.txtto redirect where they are ultimately building thingsTesting
Screenshots
Notes
Todos
Checklist
Testing checklist (automated report can be put here)
ctest