throws when variables_names_map is empty#951
Open
aaraney wants to merge 1 commit into
Open
Conversation
Contributor
|
My $0.02 here ... Absent a problem I'm not seeing with the workaround, I don't think this behavior should be modified (or at least considered) in isolation (and so these tests should not be added currently). I'm pretty sure at least model_params behaves the same way. I do strongly suspect other elements are indeed no-ops if empty, though. That's also not necessarily to say all these things should be consistent ... that seems reasonable, but it too should be more deeply examined. And honestly, I suspect the backend for configuration management could use some work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@seyounger discovered that an empty
variables_names_mapcausesngento throw the following:This PR is just a test to showcase the failure.
I would expect that this would be a no-op.