Skip to content

Fix pattern-matched init_config when using a single-module formulation#955

Merged
robertbartel merged 3 commits into
masterfrom
PhilMiller/init-config-pattern
Apr 22, 2026
Merged

Fix pattern-matched init_config when using a single-module formulation#955
robertbartel merged 3 commits into
masterfrom
PhilMiller/init-config-pattern

Conversation

@PhilMiller

@PhilMiller PhilMiller commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Spurred by testing added to cover the changes in #906

Additions

  • Test using {{id}} in the init_config property of a single-module formulation, configured either globally or for the specific catchment

Changes

  • Use configuration with {{id}} substituted for the catchment's ID in call paths for global and catchment-specific formulations

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@robertbartel robertbartel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I may come back to it in the future to add tests that more directly test things, and/or push for a larger overhaul of the configuration management code. If you have any thoughts on the latter @PhilMiller, especially in the near term, let me know. But this addresses things well for now.

@robertbartel robertbartel added the bug Something isn't working label Apr 22, 2026
@robertbartel
robertbartel merged commit 28cd6d9 into master Apr 22, 2026
20 of 21 checks passed
@robertbartel
robertbartel deleted the PhilMiller/init-config-pattern branch April 22, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants