(refacto): replace block interface{} returns with BlockWithTsx/TxHashes#842
Open
waseemnaseeven wants to merge 1 commit into
Open
(refacto): replace block interface{} returns with BlockWithTsx/TxHashes#842waseemnaseeven wants to merge 1 commit into
waseemnaseeven wants to merge 1 commit into
Conversation
bimakw
approved these changes
Jan 8, 2026
bimakw
left a comment
bimakw
left a comment
There was a problem hiding this comment.
Nice refactor! The typed wrapper approach is much cleaner than returning interface{}.
Observations:
- Switch statement pattern for handling
Block/PreConfirmedis consistent across files ✓ - Docs updated properly ✓
- Tests updated to use new wrapper types ✓
Minor: There's a small formatting issue in transaction_test.go:230 (extra indent after Return()).
Otherwise LGTM!
Collaborator
|
Hey @waseemnaseeven! Thanks for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added typed wrappers for block variants with transactions/hashes and updated the corresponding RPC methods to return these types.
Adapted the business logic (tip estimation and version detection) to explicitly handle confirmed and pre-confirmed outputs.
Updated the documentation and examples to reflect the new method signatures and the explicit selection of block variants.