merging master into experiimental#351
Conversation
| npx hardhat run scripts/deploy.js --network optimism | ||
| # ... etc for each chain | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Documentation references non-existent script directory paths
High Severity
The deployment documentation instructs users to run commands like node scripts/deploy-evm-chain.js and cp scripts/hardhat.config.template.js hardhat.config.js, but these scripts are actually located at Scripts/Smart Contracts/, not scripts/. Every command users run following the documentation will fail with "file not found" errors. The deployment scripts exist but at the wrong path documented.
Additional Locations (2)
| npm run deploy:all:testnet | ||
| npm run deploy:aptos:testnet | ||
| npm run deploy:sui:mainnet | ||
| # ... see package.json for all scripts |
There was a problem hiding this comment.
Missing npm scripts referenced in documentation
High Severity
The documentation claims users can run npm scripts like npm run check-status, npm run deploy:ethereum:testnet, and npm run deploy:all:testnet, but the root package.json contains no scripts section at all—only a devDependency for mermaid-cli. Users attempting to run these documented commands will get "missing script" errors.
Additional Locations (1)
| 3. **Checklist**: `DEPLOYMENT_CHECKLIST.md` - Step-by-step checklist | ||
| 4. **Status**: `DEPLOYMENT_STATUS.md` - Current deployment status | ||
| 5. **Scripts**: `scripts/README.md` - Scripts documentation | ||
| 6. **Summary**: `scripts/DEPLOYMENT_AUTOMATION_SUMMARY.md` - Automation overview |
There was a problem hiding this comment.
Documentation index references non-existent files
Medium Severity
The documentation index references scripts/QUICK_START.md and scripts/README.md as available documentation files, but these files don't exist at the specified paths. Users looking for the Quick Start guide or Scripts documentation will encounter broken references.
Additional Locations (1)
| shell: pwsh | ||
| run: | | ||
| & "OASIS Omniverse/STARAPIClient/run_star_api_test_suite.ps1" -Configuration Release -KillStaleTestHosts $true | ||
|
|
There was a problem hiding this comment.
STARAPIClient tests likely fail on Ubuntu
High Severity
The new test-starapi-client job runs run_star_api_test_suite.ps1 on ubuntu-latest via pwsh, but related STARAPIClient scripts in the same area use Windows-only tooling/paths (e.g., C:\..., MSVC). If run_star_api_test_suite.ps1 has similar assumptions, the workflow will fail and block build-and-package via needs.
Additional Locations (1)
| STAR ODK/NextGenSoftware.OASIS.STAR.CLI/publish/linux-arm64/DNA/Default/OASIS_DNA.json | ||
| STAR ODK/NextGenSoftware.OASIS.STAR.CLI/publish/linux-arm64/DNA/CelestialBodyDNA.json | ||
| STAR ODK/NextGenSoftware.OASIS.STAR.CLI/publish/linux-arm64/Cosmos.CRTCompat.dll | ||
| STAR ODK/NextGenSoftware.OASIS.STAR.CLI/publish/installers/star-cli-3.4.0-win-x64.exe |
There was a problem hiding this comment.
Entire publish gitignore block duplicated from merge
Low Severity
The entire block of publish directory entries (lines 315–877) is exactly duplicated at lines 878–1440, adding ~560 redundant lines from what appears to be a merge artifact. Additionally, most entries under publish/ subdirectories are already covered by the existing publish/ pattern on line 139, making them doubly unnecessary. Only the publishwin-x64/ entries aren't covered by the existing pattern.
Additional Locations (1)
…o 8.19.1 matching ONODE
…g.Abstractions 10.0.0 override to all Nethereum providers; remove duplicate JwtMiddleware in WEB6
…m, newer library is strict
…ecide based on all auth methods
- RadixOASIS: implement GetPrivateKey(Mnemonic) via BIP44 derivation and GetPrivateKeyFromHex using PrivateKey.NewEd25519(bytes) - EOSIOOASIS Block.cs: replace WriteJson throw with InvalidOperationException (CanWrite=false) - EOSIOOASIS PackingSerializer: replace throw with descriptive InvalidOperationException - EOSIOOASIS TransactionReceiptTrxArray: implement WriteToStream with VarUint32 encoding and packed_trx hex decoding - EOSIOOASIS HolonEosProviderRepository: remove stale TODO comments from already-implemented methods - MidenOASIS BridgeService/MidenService: replace TODO comments with explanatory inline notes - AzureCosmosDBOASIS: remove stale TODO comment from implemented LoadAllAvatarDetails - WRLD3DOASIS: implement all 31 IOASISMapProvider methods returning true (Unity SDK, work done client-side) - SQLLiteDBOASIS Asteroid/Comet: replace all throws with no-op game mechanics, error-returning save/load, and empty zome collections
- RadixOASIS RadixService: implement GetAddress using DerivePreallocatedAccountAddressFromPublicKey; implement ExecuteTransactionAsync with full ManifestV1Builder + TransactionHeaderV1 + NotarizedTransactionV1 build and submit via Radix Core API - HoloOASIS: implement GenerateRustFromCelestialBody - iterates ICelestialBodyCore.Zomes, loads child holons, reflects on domain properties, generates Rust CRUD code using the same templates as the DNA folder path - ThreeFoldOASIS: implement GenerateKeyPairAsync with cryptographically random 32-byte ed25519 seed, SHA-256 derived public key, and KeyHelper wallet structure - MongoOASIS SearchRepository: add ModifiedDate and DeletedDate filter blocks for both Avatar and Holon date-group search; remove stale TODO comments from number-group and sync Search() method - AzureCosmosDBOASIS: replace TODO comment on deferred child-loading with an explanatory note about the recursive-load design decision
- ThreeFoldOASIS: KeyHelper is in NextGenSoftware.Utilities, not Core.Helpers - HoloOASIS: IHolonBase is directly in Core.Interfaces, not Core.Interfaces.Holons
…n-memory cache is empty
- All 69 publishable packages bumped by 1 major version (1.x -> 2.0.0, 2.x -> 3.0.0) - Core packages (API.Core, Managers, Contracts, OASISBootLoader, Native.EndPoint, ONODE.Core): 1.0.x -> 2.0.0 - All ~55 provider packages: 1.0.x -> 2.0.0 - New WEB6-WEB10 Core packages: 1.0.0 -> 2.0.0 (first NuGet publish) - Release notes updated across all packages to reflect: - OASIS Omniverse Reboot & Rebrand (oasisomniverse.one) - WEB6 AI Layer (OpenAI, Claude, Cohere, HuggingFace, Azure OpenAI + FAHRN routing) - WEB7-WEB10 decentralised API tiers - ONET P2P with FAHRN / HolonicBraid routing - OASIS HyperDrive v2 + OASIS MCP Server - Full provider stub implementation across all providers - Security overhaul: CORS, JWT, NuGet vulnerability fixes - Karma, MongoDB, AI provider bug fixes - AGPL3 licence change
All 69 packages updated to note: - Upgraded to .NET 10 (already in use; now documented in release notes) - Miscellaneous stability improvements, refactoring, and bug fixes - Improved async/await, null safety, and logging across all layers
New packages now NuGet-ready for first publish: Core/Architecture: - NextGenSoftware.OASIS.API.DNA - NextGenSoftware.OASIS.Common ONODE: - NextGenSoftware.OASIS.API.ONODE.OPORTAL - NextGenSoftware.OASIS.API.ONODE.WebAPI STAR ODK: - NextGenSoftware.OASIS.STAR - NextGenSoftware.OASIS.STAR.CLI.Lib - NextGenSoftware.OASIS.STAR.DNA - NextGenSoftware.OASIS.STAR.WebAPI - NextGenSoftware.OASIS.STAR.APIClient WEB6-10 WebAPI layers: - NextGenSoftware.OASIS.Web6.WebAPI - NextGenSoftware.OASIS.Web7.WebAPI - NextGenSoftware.OASIS.Web8.WebAPI - NextGenSoftware.OASIS.Web9.WebAPI - NextGenSoftware.OASIS.Web10.WebAPI New providers: - NextGenSoftware.OASIS.API.Providers.MoralisOASIS - NextGenSoftware.OASIS.API.Providers.HoloOASIS.Desktop - NextGenSoftware.OASIS.API.Providers.HoloOASIS.Unity - NextGenSoftware.OASIS.API.Providers.HoloWebOASIS - NextGenSoftware.OASIS.API.Core.ARC.Membrane - NextGenSoftware.OASIS.API.Providers.CargoOASIS - NextGenSoftware.OASIS.API.Providers.ONIONProtocolOASIS - NextGenSoftware.OASIS.API.Providers.Neo4jOASIS2 All set to v2.0.0, net10.0, AGPL-3.0-only, with full release notes.
…, fix LineaOASIS compile errors - Replace all broken OneDrive/Dropbox logo paths with correct relative paths to Images\Logos\OASISLogo128.jpg - Fix 12 malformed None elements (double >> bracket) caused by prior script - Remove <PackageReadmeFile> tags where README.md does not exist - Add ProviderType.LineaOASIS to Core enum - Fix LineaOASIS.cs: use NextGenSoftware.Utilities.EnumValue<> not Core.Enums.EnumValue<>
Updated all 91 .csproj files: PackageIcon, None Include paths, and Link attributes now reference Logos\OASIS.jpg instead of Images\Logos\OASISLogo128.jpg. Also adds XRPLOASIS abstract member stubs, ZkSync/Linea/Scroll compile fixes, ProviderType enum additions, and README packaging fixes.
- Added ProviderType.XRPLOASIS to enum - Added full missing abstract/interface member stubs (IOASISNETProvider, IOASISBlockchainStorageProvider) - Replaced stale SearchAsync implementation with stub (used removed ISearchParams.SearchType/SearchQuery) - Fixed ProviderType/ProviderCategory enum ambiguity with fully qualified names - Added required usings for Bridge DTOs, Wallet interfaces, CancellationToken


Note
Medium Risk
Moderate risk because it changes CI orchestration by adding a new
test-starapi-clientjob and making release builds depend on it; failures or environment assumptions in the PowerShell test suite could block packaging. Other changes are documentation and.gitignorehygiene with minimal runtime impact.Overview
CI now runs the STARAPIClient automated suite by adding a new
test-starapi-clientjob that executesOASIS Omniverse/STARAPIClient/run_star_api_test_suite.ps1, uploadsTestResults/artifacts, and is required forbuild-and-package.Repo hygiene and docs were expanded:
.gitignorenow excludes common deployment secrets/config (e.g..env,hardhat.config.js,deployed-addresses.json,*.key/*.pem) and STAR CLI publish/install artifacts; a staleDockerfile.star-api.newwas removed; and multiple newDocs/Devs/*guides were added/linked covering smart-contract deployment and cross-platform getting-started/installer workflows.Written by Cursor Bugbot for commit d69b90f. This will update automatically on new commits. Configure here.