Skip to content

Method isTripActive able to check the delay cases in StopTimeUpdate #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TsimurSh wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Method isTripActive able to check the delay cases in StopTimeUpdate #439

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa475d7
Update GtfsRealtimeTripLibrary.java
TsimurSh Jun 5, 2025
5cd03a1
add wrap method for tests
TsimurSh Jun 20, 2025
7321006
test: add test testIsTripActive_WithDelayNoTimeAndScheduledTrip to Gt…
TsimurSh Jun 20, 2025
01d8f29
suggestions by Copilot
TsimurSh Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...ebusaway/transit_data_federation/impl/realtime/gtfs_realtime/GtfsRealtimeTripLibrary.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,10 @@ public VehicleLocationRecord createVehicleLocationRecordForUpdate(MonitoredResul
return record;
}

public boolean getIsTripActive(CombinedTripUpdatesAndVehiclePosition update) {
return this.isTripActive(update);
}

private boolean isTripActive(CombinedTripUpdatesAndVehiclePosition update) {
if (update.getTripUpdates().isEmpty())
return false;
Expand All @@ -615,6 +619,14 @@ private boolean isTripActive(CombinedTripUpdatesAndVehiclePosition update) {
long lastPrediction = -1;
StopTimeUpdate firstStopTime = tripUpdate.getStopTimeUpdate(0);
StopTimeUpdate lastStopTime = tripUpdate.getStopTimeUpdate(tripUpdateCount-1);

if (lastStopTime.hasArrival())
if (!lastStopTime.getArrival().hasTime()
&& lastStopTime.getArrival().hasDelay()
&& tripUpdate.getTrip().getScheduleRelationship()
.equals(TripDescriptor.ScheduleRelationship.SCHEDULED))
return true;
Comment thread
TsimurSh marked this conversation as resolved.
Outdated

if (firstStopTime.hasArrival())
firstPrediction = firstStopTime.getArrival().getTime();
else if (firstStopTime.hasDeparture())
Expand Down
28 changes: 28 additions & 0 deletions ...away/transit_data_federation/impl/realtime/gtfs_realtime/GtfsRealtimeTripLibraryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,6 +829,34 @@ public void testCombinedUpdateWithRealtimeVehicleAndAnonVehicle() {
assertEquals("tripC", c.getTripUpdates().get(2).getTrip().getTripId());
}

@Test
public void testIsTripActive_WithDelayNoTimeAndScheduledTrip() {

StopTimeEvent arrival = StopTimeEvent.newBuilder()
.setDelay(30)
.build();

StopTimeUpdate stopTimeUpdate = StopTimeUpdate.newBuilder()
.setArrival(arrival)
.build();

TripDescriptor tripDescriptor = TripDescriptor.newBuilder()
.setScheduleRelationship(TripDescriptor.ScheduleRelationship.SCHEDULED)
.build();

TripUpdate tripUpdate = TripUpdate.newBuilder()
.setTrip(tripDescriptor)
.addStopTimeUpdate(stopTimeUpdate)
.build();

CombinedTripUpdatesAndVehiclePosition update = new CombinedTripUpdatesAndVehiclePosition();
update.setTripUpdates(List.of(tripUpdate));
// Act
boolean result = _library.getIsTripActive(update);
// Assert
assertTrue("Trip should be active when StopTimeUpdate has delay and trip is SCHEDULED.", result);
}

private static FeedMessage.Builder createFeed() {
FeedMessage.Builder builder = FeedMessage.newBuilder();
FeedHeader.Builder header = FeedHeader.newBuilder();
Expand Down