feat(api): update OpenAI Codex models for GPT-5.6 (re-land #147)#148
Conversation
Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
# Conflicts: # docs/providers.md # src-rust/crates/api/src/model_registry.rs # src-rust/crates/api/src/providers/codex.rs # src-rust/crates/tui/src/dialog_select.rs # src-rust/crates/tui/src/model_picker.rs # src-rust/crates/tui/src/onboarding_dialog.rs
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BunsDev
left a comment
There was a problem hiding this comment.
Reviewed the post-merge delta (4 files, +32/−10) line by line.
Correctness
model_registry.rs: GPT-5.6 family added at the head of theopenaiflagship patterns — ordering gives sol > terra > luna > family > 5.5 preference, matching the anthropic list's structure. Test assertions now pin the codex best/small fallbacks toDEFAULT_CODEX_MODEL/gpt-5.6-lunainstead of only asserting membership — stronger regression net.api/src/lib.rs: twoneedless_borrowfixes informat!args; behavior-identical.tui/src/app.rs:EnvGuardcorrectly snapshotsCLAUDE_BIN_ENVat construction, clears it for the test body, restores on drop — same pattern as the other guarded vars. The rewritten provider-picker test drops the imported-credentials fixture in favor of a localclaudebinary override, consistent with the no-imported-OAuth-tokens policy (fb989ab). Windowsclaude.cmdcase handled.docs/providers.md: description refresh only.
Conventions — commit style, no unwraps on fallible paths, docs updated. Conflict resolution against 4751ee8 kept main's newer sourced context windows (372K for the 5.6 family); nothing from main was regressed.
Verification — local: cargo fmt (no changes), cargo check --workspace, cargo clippy --workspace --all-targets -- -D warnings, cargo test --workspace (1852 passed, 0 failed).
Nitpick, non-blocking: the bare "gpt-5.6" pattern is redundant given the three concrete ids above it, but it is a harmless family fallback.
Ready to merge once CI is green.
There was a problem hiding this comment.
Pull request overview
Re-lands and updates the Codex/OpenAI model catalog and defaults to the GPT-5.6 family, alongside small test-environment and TUI provider-picker test stabilization to keep workspace tests deterministic.
Changes:
- Update model-registry “flagship” heuristics and tests to align Codex defaults with
DEFAULT_CODEX_MODELand the GPT-5.6 family. - Stabilize TUI provider-picker tests by using deterministic Claude CLI binary discovery via
COVEN_CODE_CLAUDE_BINand ensuring the test env guard restores that env var. - Minor clippy-driven formatting cleanup for bearer auth header formatting; docs wording tweak for the legacy Codex model.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src-rust/crates/tui/src/app.rs | Test env guard now snapshots/restores COVEN_CODE_CLAUDE_BIN; provider picker test uses a temp “claude” binary path for deterministic local detection. |
| src-rust/crates/api/src/model_registry.rs | Adds GPT-5.6 family patterns to OpenAI flagship selection; strengthens Codex fallback assertions in tests. |
| src-rust/crates/api/src/lib.rs | Removes redundant borrows in format! calls for Authorization header (clippy cleanup). |
| docs/providers.md | Adjusts the gpt-5.2-codex description to “Legacy … compatibility model”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "openai" => &[ | ||
| "gpt-5.6-sol", | ||
| "gpt-5.6-terra", | ||
| "gpt-5.6-luna", | ||
| "gpt-5.6", | ||
| "gpt-5.5", |
Summary
Context
pr-147-openai-modelsre-lands that work with local fixes.Changes
feat(api): update OpenAI Codex models— GPT-5.6 model family in the Codex catalog.fix(api)/fix(tui)— clippy formatting lint, provider picker credential test stabilization, test-home env race fix.docs: update codex default model to gpt-5.6-sol.mainback in; conflicts with 4751ee8 ("Refresh Codex defaults for GPT-5.6") resolved in favor of main's newer refresh (372K context windows for the 5.6 family per the upstream models.json catalog, simplified efficient-tier selection, updated labels). The branch's unique test fixes are preserved.Validation
git diff --check— cleancargo fmt --all— no changescargo check --workspace— Finished, no warningscargo clippy --workspace --all-targets -- -D warnings— Finished, no lintscargo test --workspace— 1852 passed, 0 failedPR Readiness
🤖 Generated with Claude Code